cms-sw
(DAQ) fix input source cv notification [14_0_X]
PR description:
Bugfix for DAQ input sources fixing the issue where notification via condition variable is not passed between threads, resulting in acting only after a timeout of 0.1s. Generally not a problem in data taking, but was limiting file rate to 10Hz and was a limitation in high-rate MiniDAQ runs.
Applied also to DAQSource (used for scouting) where same logic is used.
PR validation:
Tested in live miniDAQ system with a patched CMSSW version
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44979 Reason for backport: online bugfix for MiniDAQs
A new Pull Request was created by @smorovic for CMSSW_14_0_X.
It involves the following packages:
- EventFilter/Utilities (daq)
@cmsbuild, @smorovic, @emeschi can you please review it and eventually sign? Thanks. @missirol, @Martin-Grunewald this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
-1
Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bbb81/39391/summary.html
COMMIT: a9f79eb798c380db618916db427878cb430cebca
CMSSW: CMSSW_14_0_X_2024-05-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44980/39391/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals-INPUT
- 4.76
4.76_ZMuSkim2012D/step2_ZMuSkim2012D.log
Comparison Summary
Summary:
- You potentially removed 26 lines from the logs
- Reco comparison results: 49 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3333953
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3333930
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bbb81/39402/summary.html
COMMIT: a9f79eb798c380db618916db427878cb430cebca
CMSSW: CMSSW_14_0_X_2024-05-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44980/39402/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 96 lines from the logs
- Reco comparison results: 59 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3333953
- DQMHistoTests: Total failures: 1199
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3332734
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
