cms-sw
(DAQ) fix input source cv notification [14_1_X]
PR description:
Bugfix for DAQ input sources fixing the issue where notification via condition variable is not passed between threads, resulting in acting only after a timeout of 0.1s. Generally not a problem in data taking, but was limiting file rate to 10Hz and was a limitation in high-rate MiniDAQ runs.
Applied also to DAQSource (used for scouting) where same logic is used.
PR validation:
Tested in live miniDAQ system with a patched CMSSW version
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44979/40260
-
This PR adds an extra 36KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): #44892
A new Pull Request was created by @smorovic for master.
It involves the following packages:
- EventFilter/Utilities (daq)
@cmsbuild, @smorovic, @emeschi can you please review it and eventually sign? Thanks. @missirol, @Martin-Grunewald this is something you requested to watch as well. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
-1
Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29fe0e/39390/summary.html
COMMIT: 08efc8cf6569d953ea389e26cae77a008c45d858
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44979/39390/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals-INPUT
- 4.76
4.76_ZMuSkim2012D/step2_ZMuSkim2012D.log
Comparison Summary
Summary:
- You potentially added 3 lines to the logs
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338976
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338953
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29fe0e/39397/summary.html
COMMIT: 08efc8cf6569d953ea389e26cae77a008c45d858
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44979/39397/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338976
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338953
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
