cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[JMENano] Add customize functions to recompute Puppi and PuppiMET

Open nurfikri89 opened this issue 1 year ago • 6 comments

PR description:

This PR adds two wrapper functions which

  • set the PuppiProducer instances (packedpuppi & packedpuppiNoLep) to recompute puppi weights.
  • setup the recalculation of PuppiMET.

The two functions can be setup in cmsRun config files using --customise or -customize_commands arguments of cmsDriver.py. This would be useful if a (official or private) JMENano production needs updated puppi weights.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

No changes are expected to any workflow because the two functions are not being called anywhere.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X

nurfikri89 avatar May 15 '24 08:05 nurfikri89

cms-bot internal usage

cmsbuild avatar May 15 '24 08:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44972/40256

  • This PR adds an extra 28KB to repository

cmsbuild avatar May 15 '24 09:05 cmsbuild

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @hqucms, @vlimant can you please review it and eventually sign? Thanks. @AnnikaStein, @gpetruc this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 15 '24 09:05 cmsbuild

enable nano

hqucms avatar May 15 '24 09:05 hqucms

@nurfikri89 Could you please add a matrix workflow to test these functions?

hqucms avatar May 15 '24 09:05 hqucms

@nurfikri89 Could you please add a matrix workflow to test these functions?

Sure I can do this

nurfikri89 avatar May 15 '24 09:05 nurfikri89

@nurfikri89 : where are you with adding a test workflow for this ?

vlimant avatar May 31 '24 07:05 vlimant

@nurfikri89 : where are you with adding a test workflow for this ?

@vlimant My apologies. I encountered some problems on getting this done for the past few weeks. I aim to get this done this week.

nurfikri89 avatar Jun 02 '24 20:06 nurfikri89

Closing this PR and will submit a new one. Had a problem with base release of my local branch.

nurfikri89 avatar Jun 07 '24 09:06 nurfikri89