cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking

Open patinkaew opened this issue 1 year ago • 52 comments

PR description:

This PR adds two versions of scouting muon collections, ScoutingMuonNoVtx and ScoutingMuonVtx, following this change CMSHLT-3089:Add hltScoutingMuonPackerVtx to Scouting EventContent.

This fixes issue Missing "hltScoutingMuonPacker" in ScoutingNANO using recent Run-3 data#44817.

This PR also introduces run3_scouting_nanoAOD_post2023 Modifier used to modify configuration and top level Run3_post2023 ModifierChain based on Run3 with run3_scouting_nanoAOD_post2023 Modifier.

PR validation:

Tested by producing scouting NanoAOD from a 2024 scouting HLTSCOUT datatier file using the following cmsDriver.py command:

cmsDriver.py step2 -s NANO:@Scout --process NANO \
--data --eventcontent NANOAOD --datatier NANOAOD -n 10000 \
--era Run3_post2023 --conditions auto:run3_data --filein fileIN.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but backport to 140X will follow.

cc: @elfontan @karim @silviodonato @vlimant

patinkaew avatar May 14 '24 11:05 patinkaew

cms-bot internal usage

cmsbuild avatar May 14 '24 11:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40251

  • This PR adds an extra 28KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/StandardSequences/python/Eras.py modified in PR(s): #33532, #43761

cmsbuild avatar May 14 '24 11:05 cmsbuild

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/NanoAOD (xpog)

@rappoccio, @hqucms, @fabiocos, @vlimant, @antoniovilela, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @rovere, @slomeo, @fabiocos, @felicepantaleo, @VourMa, @VinInn, @sameasy, @missirol, @makortel, @mtosi, @mmusich, @gpetruc, @Martin-Grunewald, @JanFSchulte, @AnnikaStein, @dgulhan this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 14 '24 11:05 cmsbuild

please include a test workflow in the nano matrix

vlimant avatar May 14 '24 12:05 vlimant

enable nano

vlimant avatar May 14 '24 12:05 vlimant

our initial comment in #44817 about having Run3_post2023 instead of Run3_2024 and Run3_2025 was to simplify things and limit the number of modifiers. if @cms-sw/orp-l2 and others feel otherwise, we might roll back to Run3_2024 and Run3_2025

vlimant avatar May 14 '24 12:05 vlimant

@patinkaew : please go ahead and modify back to Run3_2024 and we will also need a dedicated "scenario" (similar to https://github.com/cms-sw/cmssw/blob/master/Configuration/DataProcessing/python/Impl/ppEra_Run3_2023.py) to be able to run this at Tier0 ; I'm rusty with how to implement this exactly ...

vlimant avatar May 21 '24 15:05 vlimant

lease go ahead and modify back to Run3_2024 and we will also need a dedicated "scenario"

This is what was already done in https://github.com/cms-sw/cmssw/pull/43761 (now amended to comply with PPD prescription). This PR could simply piggy-back on that one (once merged).

mmusich avatar May 22 '24 08:05 mmusich

Thanks. I'm waiting for #43761 to get merged and then I will make changes accordingly.

patinkaew avatar May 24 '24 22:05 patinkaew

Thanks. I'm waiting for https://github.com/cms-sw/cmssw/pull/43761 to get merged and then I will make changes accordingly.

@patinkaew, #43761 is now merged.

mmusich avatar Jun 12 '24 07:06 mmusich

@vlimant, I rebased to latest IB release (CMSSW_14_1_X_2024-06-12-1900) with https://github.com/cms-sw/cmssw/pull/43761 merged and changed from Era_Run3_post2023 to use Era_Run3_2024.

I re-validated this change with

cmsDriver.py step2 -s NANO:@Scout --process NANO \
--data --eventcontent NANOAOD --datatier NANOAOD -n 10000 \
--era Run3_2024 --conditions auto:run3_data --filein fileIN.root

and the output NanoAOD file looks good.

patinkaew avatar Jun 12 '24 22:06 patinkaew

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40563

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • Configuration/Eras/python/Era_Run3_post2023_cff.py:
      • Added: 8e6f905f999da0bf0e72abaab06da835d553375e
      • Deleted: c71b006b0aa7f3e0ae1c77aeaccbf3ccfe1c3dee

cmsbuild avatar Jun 12 '24 22:06 cmsbuild

Pull request #44970 was updated. @hqucms, @fabiocos, @rappoccio, @antoniovilela, @ftorrresd, @davidlange6, @vlimant, @cmsbuild can you please check and sign again.

cmsbuild avatar Jun 12 '24 22:06 cmsbuild

thanks. next step is to add the nano in the scouting scenario for that era. @drkovalskyi ; what is the scenario currently being run on the scouting dataset, if any ?

vlimant avatar Jun 13 '24 05:06 vlimant

and also, as previously requested to add a test workflow for that era in the nano matrix, similar to the one already in place

vlimant avatar Jun 13 '24 05:06 vlimant

We don't run reco of any sort on HLTSCOUT, just repacking, which keeps everything included by TSG in the stream.

drkovalskyi avatar Jun 13 '24 06:06 drkovalskyi

ok, thanks. any suggestion on a scenario name + method name that we need to implement. Can this be a method of ppEra_Run3_2024 scenario, or should it be hltScouting_Run3_2024::promptReco (to be implemented here) ?

vlimant avatar Jun 13 '24 07:06 vlimant

I would suggest to keep code expecting non-standard input data format separately from the prompt reco that takes RAW data as input, i.e. hltScouting_Run3_2024::promptReco seems like a better option to me. Let's see what @germanfgv thinks.

drkovalskyi avatar Jun 13 '24 07:06 drkovalskyi

I agree with @drkovalskyi. Please implement a separate scenario for PromptReco using HLTSCOUT data tier as input. We can assign it to the appropriate datasets in the Tier0 configuration.

germanfgv avatar Jun 13 '24 08:06 germanfgv

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40587

  • This PR adds an extra 36KB to repository

  • Found files with invalid states:

    • Configuration/Eras/python/Era_Run3_post2023_cff.py:
      • Added: 8e6f905f999da0bf0e72abaab06da835d553375e
      • Deleted: c71b006b0aa7f3e0ae1c77aeaccbf3ccfe1c3dee

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #45167

cmsbuild avatar Jun 14 '24 03:06 cmsbuild

Pull request #44970 was updated. @fabiocos, @miquork, @vlimant, @cmsbuild, @rappoccio, @srimanob, @ftorrresd, @sunilUIET, @kskovpen, @hqucms, @subirsarkar, @davidlange6, @AdrianoDee, @antoniovilela can you please check and sign again.

cmsbuild avatar Jun 14 '24 03:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40588

  • This PR adds an extra 40KB to repository

  • Found files with invalid states:

    • Configuration/Eras/python/Era_Run3_post2023_cff.py:
      • Added: 8e6f905f999da0bf0e72abaab06da835d553375e
      • Deleted: c71b006b0aa7f3e0ae1c77aeaccbf3ccfe1c3dee

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #45167

cmsbuild avatar Jun 14 '24 04:06 cmsbuild

Pull request #44970 was updated. @hqucms, @srimanob, @subirsarkar, @vlimant, @kskovpen, @davidlange6, @sunilUIET, @antoniovilela, @miquork, @cmsbuild, @ftorrresd, @fabiocos, @AdrianoDee, @rappoccio can you please check and sign again.

cmsbuild avatar Jun 14 '24 04:06 cmsbuild

Hi all,

Scenario: Referencing Reco.py, pp.py, and DataScouting.py, I make base hltScouting scenario similar to RECO+pp and specific hltScoutingEra_Run3_2024. In case we want to produce also 2022-2023 HLT scouting data (which is in RAW, but has similar eventContent), we should be able to reuse base hltScouting scenario.

I validate with recent HLTSCOUT file with the following command. It ran, but I just checked and the output file is not in NANO format so I'm debugging this.

python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario=hltScoutingEra_Run3_2024 \
--global-tag=140X_dataRun3_HLT_v3 --nanoaod --nanoFlavours=@Scout --lfn=/XX/HLTSCOUT/YY.root

NANO Matrix:

I added a workflow in NANO matrix taking HLTSCOUT data and it works. I validate with

runTheMatrix.py -l 2500.6

patinkaew avatar Jun 14 '24 05:06 patinkaew

looks good !

vlimant avatar Jun 14 '24 08:06 vlimant

please test

vlimant avatar Jun 14 '24 08:06 vlimant

@germanfgv @drkovalskyi ; all good with the scenario implementation for Tier0?

vlimant avatar Jun 14 '24 08:06 vlimant

I leave it to @germanfgv to check it. We will need to do a proper test with a Tier-0 replay to make sure everything works properly when we have this code integrated into a release.

drkovalskyi avatar Jun 14 '24 08:06 drkovalskyi

I make base hltScouting scenario similar to RECO+pp and specific hltScoutingEra_Run3_2024. In case we want to produce also 2022-2023 HLT scouting data (which is in RAW, but has similar eventContent), we should be able to reuse base hltScouting scenario.

should the new scenario be added in the unit test suite of the Configuration/DataProcessing package, e.g. here:

https://github.com/cms-sw/cmssw/blob/babb58fca451d00a49fce98204870f36aea9d4e8/Configuration/DataProcessing/test/run_CfgTest_8.sh#L13

mmusich avatar Jun 14 '24 08:06 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91e61c/39888/summary.html COMMIT: 2a4fb5e70a3bdbda1fd2bbe0440435f095063a79 CMSSW: CMSSW_14_1_X_2024-06-13-2300/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44970/39888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344989
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 52 log files, 30 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.6-size.json
  • Nano ERROR: Missing ref/2500.6-size.json | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 2500.0 | 2.783 | 2.783 | 0.000 ( +0.0% ) | 3.26 | 3.23 | +1.2% | 2.267 | 2.256 | | 2500.001 | 2.897 | 2.897 | 0.000 ( +0.0% ) | 2.90 | 2.88 | +0.9% | 2.626 | 2.678 | | 2500.002 | 2.843 | 2.843 | 0.000 ( +0.0% ) | 3.01 | 3.01 | +0.0% | 2.615 | 2.652 | | 2500.01 | 1.446 | 1.446 | 0.000 ( +0.0% ) | 5.53 | 5.49 | +0.7% | 2.308 | 2.315 | | 2500.011 | 1.906 | 1.906 | 0.000 ( +0.0% ) | 3.03 | 3.03 | -0.0% | 2.444 | 2.449 | | 2500.012 | 1.761 | 1.761 | 0.000 ( +0.0% ) | 4.37 | 4.33 | +1.0% | 2.426 | 2.400 | | 2500.1 | 2.353 | 2.353 | 0.000 ( +0.0% ) | 4.06 | 4.05 | +0.1% | 2.084 | 2.082 | | 2500.2 | 2.459 | 2.459 | 0.000 ( +0.0% ) | 4.62 | 4.60 | +0.5% | 1.989 | 1.995 | | 2500.21 | 1.285 | 1.285 | 0.000 ( +0.0% ) | 3.04 | 2.99 | +1.7% | 2.290 | 2.290 | | 2500.211 | 1.668 | 1.668 | 0.000 ( +0.0% ) | 2.78 | 2.72 | +2.2% | 2.370 | 2.367 | | 2500.3 | 2.229 | 2.229 | 0.000 ( +0.0% ) | 8.32 | 8.22 | +1.2% | 1.974 | 1.975 | | 2500.301 | 2.833 | 2.833 | 0.000 ( +0.0% ) | 7.36 | 7.32 | +0.5% | 1.964 | 1.962 | | 2500.31 | 7.164 | 7.164 | 0.000 ( +0.0% ) | 1.42 | 1.44 | -1.8% | 1.711 | 1.710 | | 2500.311 | 1.568 | 1.568 | 0.000 ( +0.0% ) | 8.11 | 8.32 | -2.5% | 1.065 | 1.061 | | 2500.312 | 540.338 | 540.338 | 0.000 ( +0.0% ) | 0.50 | 0.50 | +0.6% | 1.605 | 1.603 | | 2500.313 | 816.269 | 816.269 | 0.000 ( +0.0% ) | 0.70 | 0.71 | -1.0% | 1.582 | 1.580 | | 2500.32 | 1.348 | 1.348 | 0.000 ( +0.0% ) | 9.55 | 9.44 | +1.1% | 2.367 | 2.370 | | 2500.321 | 1.757 | 1.757 | 0.000 ( +0.0% ) | 8.41 | 8.20 | +2.6% | 2.449 | 2.448 | | 2500.322 | 1.236 | 1.236 | 0.000 ( +0.0% ) | 8.36 | 8.07 | +3.6% | 2.110 | 2.128 | | 2500.323 | 7.642 | 7.642 | 0.000 ( +0.0% ) | 3.83 | 3.66 | +4.8% | 1.841 | 1.938 | | 2500.324 | 1.874 | 1.874 | 0.000 ( +0.0% ) | 8.45 | 8.31 | +1.7% | 2.229 | 2.183 | | 2500.325 | 4.136 | 4.136 | 0.000 ( +0.0% ) | 3.87 | 3.78 | +2.3% | 2.194 | 2.173 | | 2500.326 | 3.342 | 3.342 | 0.000 ( +0.0% ) | 1.38 | 1.37 | +1.3% | 2.108 | 2.104 | | 2500.327 | 1.811 | 1.811 | 0.000 ( +0.0% ) | 8.39 | 8.12 | +3.3% | 2.291 | 2.300 | | 2500.4 | 2.374 | 2.374 | 0.000 ( +0.0% ) | 7.94 | 7.88 | +0.9% | 1.872 | 1.873 | | 2500.401 | 1.891 | 1.891 | 0.000 ( +0.0% ) | 7.33 | 7.21 | +1.6% | 1.728 | 1.732 | | 2500.402 | 2.950 | 2.950 | 0.000 ( +0.0% ) | 7.33 | 7.18 | +2.0% | 1.827 | 1.761 | | 2500.403 | 8.700 | 8.700 | 0.000 ( +0.0% ) | 2.67 | 2.65 | +0.8% | 1.786 | 1.809 | | 2500.404 | 5.474 | 5.474 | 0.000 ( +0.0% ) | 1.03 | 1.02 | +1.6% | 1.845 | 1.847 | | 2500.405 | 2.860 | 2.860 | 0.000 ( +0.0% ) | 7.30 | 7.07 | +3.3% | 1.749 | 1.748 | | 2500.5 | 5.194 | 5.194 | 0.000 ( +0.0% ) | 15.03 | 14.95 | +0.5% | 1.530 | 1.534 | | 2500.51 | 9.120 | 9.120 | 0.000 ( +0.0% ) | 9.33 | 9.24 | +0.9% | 1.401 | 1.402 |

cmsbuild avatar Jun 14 '24 11:06 cmsbuild