cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Run3-alca247X Add possibility to uncorrect the RecHit energies for AlCaReco tests

Open bsunanda opened this issue 1 year ago • 12 comments

PR description:

Add possibility to uncorrect the RecHit energies for AlCaReco tests

PR validation:

Tested by creating the flat trees with uncorrected energies

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar May 14 '24 04:05 bsunanda

cms-bot internal usage

cmsbuild avatar May 14 '24 04:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44967/40244

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44967/40244/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44967/40244/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 14 '24 04:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44967/40246

  • This PR adds an extra 28KB to repository

cmsbuild avatar May 14 '24 04:05 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Calibration/HcalCalibAlgos (alca)

@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks. @mmusich, @tocheng, @rsreds, @yuanchao this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 14 '24 04:05 cmsbuild

@cmsbuild Please test

bsunanda avatar May 14 '24 05:05 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e0b0c/39368/summary.html COMMIT: 2d4c720b9e03e485f3ef33d6c607cc7e2ac30563 CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44967/39368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3339016
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338990
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 14 '24 08:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44967/40249

  • This PR adds an extra 32KB to repository

cmsbuild avatar May 14 '24 08:05 cmsbuild

Pull request #44967 was updated. @saumyaphor4252, @perrotta, @cmsbuild, @consuegs can you please check and sign again.

cmsbuild avatar May 14 '24 08:05 cmsbuild

@cmsbuild Please test

bsunanda avatar May 14 '24 13:05 bsunanda

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e0b0c/39374/summary.html COMMIT: 8b9fb417d9d7a261d321e599da2ba73b99a723e6 CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44967/39374/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3339016
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338993
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 14 '24 15:05 cmsbuild

+alca

  • RelValInput error is unrelated

perrotta avatar May 14 '24 19:05 perrotta

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 14 '24 19:05 cmsbuild

+1

rappoccio avatar May 20 '24 14:05 rappoccio

@rappoccio an explicit "merge" is needed here, because of the test failure

perrotta avatar May 20 '24 15:05 perrotta

merge

rappoccio avatar May 22 '24 15:05 rappoccio