cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Phase2-hgc355A Complete the PR #44907 by adding the dd4hep of the algorithm DDHGCalPassive to be used for the V19 Geometry of HGCal

Open bsunanda opened this issue 1 year ago • 8 comments

PR description:

Complete PR #44907 by adding the dd4hep of the algorithm DDHGCalPassive to be used for the V19 Geometry of HGCal

PR validation:

Use the test in #44907

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar May 14 '24 04:05 bsunanda

cms-bot internal usage

cmsbuild avatar May 14 '24 04:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44966/40243

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44966/40243/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44966/40243/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 14 '24 04:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44966/40245

  • This PR adds an extra 20KB to repository

cmsbuild avatar May 14 '24 04:05 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@bsunanda, @Dr15Jones, @makortel, @mdhildreth, @srimanob, @cmsbuild, @civanch, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 14 '24 04:05 cmsbuild

@cmsbuild Please test

bsunanda avatar May 14 '24 04:05 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d5f2c/39367/summary.html COMMIT: dcf2e628b5da6092f39c22af3444eb4492851f8b CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44966/39367/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3339016
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338990
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 14 '24 08:05 cmsbuild

+1

civanch avatar May 16 '24 11:05 civanch

Hi @bsunanda Is this PR used the DD4hep workflow, or to use, i.e. something to implement in coming PR? Thx.

srimanob avatar May 16 '24 12:05 srimanob

@srimanob This will be used in a future code for silicon modules of HGCal. The code is under testing

bsunanda avatar May 22 '24 08:05 bsunanda

+Upgrade

srimanob avatar May 22 '24 09:05 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 22 '24 09:05 cmsbuild

+1

rappoccio avatar May 22 '24 15:05 rappoccio