cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Add D110 Default Input Dataset

Open AdrianoDee opened this issue 1 year ago • 26 comments

This PR proposes the addition of a default dataset for D110 geometry. To be used, also, for the standard MinBias input and the inputs for the bot tests (to be introduced after this PR).

AdrianoDee avatar May 13 '24 15:05 AdrianoDee

cms-bot internal usage

cmsbuild avatar May 13 '24 15:05 cmsbuild

test parameters:

  • workflows=29634.0,29834.0,29834.402

AdrianoDee avatar May 13 '24 15:05 AdrianoDee

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44965/40238

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #44928, #44932, #44964

cmsbuild avatar May 13 '24 15:05 cmsbuild

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@cmsbuild, @sunilUIET, @AdrianoDee, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @makortel, @slomeo, @missirol, @fabiocos this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 13 '24 15:05 cmsbuild

please test

AdrianoDee avatar May 13 '24 15:05 AdrianoDee

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8522/39363/summary.html COMMIT: 13e3b391b06d9d80eb3737b4ea43c6fad46af242 CMSSW: CMSSW_14_1_X_2024-05-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44965/39363/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 29834.402, 29834.0

cmsbuild avatar May 13 '24 17:05 cmsbuild

test parameters:

  • workflows=29634.0,29834.0,29834.402
  • workflow_opts = -w upgrade

AdrianoDee avatar May 14 '24 06:05 AdrianoDee

please test

AdrianoDee avatar May 14 '24 06:05 AdrianoDee

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44965/40247

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #44928, #44964

cmsbuild avatar May 14 '24 06:05 cmsbuild

Pull request #44965 was updated. @subirsarkar, @srimanob, @miquork, @AdrianoDee, @sunilUIET can you please check and sign again.

cmsbuild avatar May 14 '24 06:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44965/40248

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #44928, #44964

cmsbuild avatar May 14 '24 06:05 cmsbuild

Pull request #44965 was updated. @srimanob, @subirsarkar, @AdrianoDee, @sunilUIET, @miquork, @cmsbuild can you please check and sign again.

cmsbuild avatar May 14 '24 06:05 cmsbuild

please test

AdrianoDee avatar May 14 '24 06:05 AdrianoDee

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8522/39372/summary.html COMMIT: 32e2ad96b63a2a84f58807e612cc54fa2cde2c07 CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44965/39372/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 14-May-2024 09:49:08 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 14-May-2024 09:49:08 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

cmsbuild avatar May 14 '24 08:05 cmsbuild

hold

  • will updated with a new dataset with a new GT string in production (GS only)

AdrianoDee avatar May 14 '24 09:05 AdrianoDee

Pull request has been put on hold by @AdrianoDee They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar May 14 '24 09:05 cmsbuild

please test

AdrianoDee avatar May 27 '24 09:05 AdrianoDee

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44965/40360

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #45005

cmsbuild avatar May 27 '24 09:05 cmsbuild

Pull request #44965 was updated. @srimanob, @AdrianoDee, @subirsarkar, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar May 27 '24 09:05 cmsbuild

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8522/39537/summary.html COMMIT: 684c390b2b80c5146c771468d4585c972b15b143 CMSSW: CMSSW_14_1_X_2024-05-26-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44965/39537/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

  • 29834.402A fatal system signal has occurred: abort signal

cmsbuild avatar May 27 '24 12:05 cmsbuild

test parameters:

  • workflows=29634.0,29834.0
  • workflow_opts = -w upgrade

AdrianoDee avatar May 27 '24 12:05 AdrianoDee

please test

AdrianoDee avatar May 27 '24 12:05 AdrianoDee

The failure is related specifically to *.402 with D110 so technically not related to this PR for the inputs. I would decouple the two and investigate it in another context.

AdrianoDee avatar May 27 '24 12:05 AdrianoDee

unhold

AdrianoDee avatar May 27 '24 16:05 AdrianoDee

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8522/39541/summary.html COMMIT: 684c390b2b80c5146c771468d4585c972b15b143 CMSSW: CMSSW_14_1_X_2024-05-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44965/39541/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline: 29834.0 step 2 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 41 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3436810
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3436784
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 209 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 27 '24 17:05 cmsbuild

+pdmv (workflows with D110 inputs successful)

AdrianoDee avatar May 28 '24 09:05 AdrianoDee

+Upgrade

srimanob avatar May 31 '24 14:05 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 31 '24 14:05 cmsbuild

+1

rappoccio avatar Jun 03 '24 14:06 rappoccio