cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Fix relval embedding workflows

Open harrypuuter opened this issue 1 year ago • 13 comments

PR description:

This PR fixes the RelVal Workflow for TauEmbedding mentioned here https://github.com/cms-sw/cmssw/issues/44896 In addition, RelVal Workflows for all Run 2 Eras are added.

PR validation:

Workflows were validated locally.

harrypuuter avatar May 08 '24 14:05 harrypuuter

cms-bot internal usage

cmsbuild avatar May 08 '24 14:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44928/40204

  • This PR adds an extra 64KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #44925

cmsbuild avatar May 08 '24 14:05 cmsbuild

A new Pull Request was created by @harrypuuter for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @srimanob, @cmsbuild, @sunilUIET, @miquork, @subirsarkar can you please review it and eventually sign? Thanks. @slomeo, @fabiocos, @missirol, @Martin-Grunewald, @makortel this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 08 '24 14:05 cmsbuild

please test

jfernan2 avatar May 09 '24 07:05 jfernan2

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb046e/39320/summary.html COMMIT: ea45e51639d990bcfdd5aa9b9b5e648d9ea6fe6a CMSSW: CMSSW_14_1_X_2024-05-08-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44928/39320/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

ValueError: Undefined workflows: 136.9

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332450
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 09 '24 10:05 cmsbuild

136.9 was replaced with four tests 136.90(1-4). The test 136.9 does not exist anymore. Where do I find the definition of the tests to be run?

harrypuuter avatar May 09 '24 11:05 harrypuuter

136.9 may used in several places, I am not sure if we can simply remove it, why don't you just add the extra wfs in addition to 136.9? Perhaps @smuzaffar can answer your question

jfernan2 avatar May 10 '24 15:05 jfernan2

For INPUT test, currently bot tries to run all workflows defined in IB. This is bug on bot side and I will fix it next week

smuzaffar avatar May 11 '24 10:05 smuzaffar

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb046e/39320/summary.html COMMIT: ea45e51639d990bcfdd5aa9b9b5e648d9ea6fe6a CMSSW: CMSSW_14_1_X_2024-05-08-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44928/39320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332450
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 12 '24 10:05 cmsbuild

@cms-sw/pdmv-l2 please sign as this fixes a long running failure in the IBs.

Dr15Jones avatar May 14 '24 13:05 Dr15Jones

+Upgrade

srimanob avatar May 14 '24 14:05 srimanob

+pdmv

AdrianoDee avatar May 16 '24 08:05 AdrianoDee

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 16 '24 08:05 cmsbuild

+1

rappoccio avatar May 20 '24 14:05 rappoccio