Introduce OnlinePopCon mechanism
PR description:
This PR introduces a new OnlinePopCon mechanism that will serve the O2Os aiming at writing lumi-based IOVs for HLT. The implementation is following the same structure of the already existing PopCon mechanism:
PopCon--> DB upload throughPoolDBOutputServiceOnlinePopCon--> DB upload throughOnlineDBOutputService
and it is largely borrowed from the PopCon code itself, with the appropriate/minimal changes required for running the OnlineDBOutputService.
The first and only (for now) customer of this mechanism are the LHCInfoPerLS and LHCInfoPerFill O2O, when run in "duringFill mode".
Opening as draft since there are still a few open points to address:
- [x] Understand if
m_dbService->forceInit();(copied from PopCon) is needed also in OnlinePopCon - [ ] Add a unit-test
- [x] Confirm all the needed methods are present
PR Validation
Code compiles, but no other specific validation is done for now.
Backport:
Not a backport. A backport for the 2024 data-taking release will be opened once we converge on this PR.
FYI @JanChyczynski
cms-bot internal usage
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40203
- This PR adds an extra 20KB to repository
A new Pull Request was created by @francescobrivio for master.
It involves the following packages:
- CondCore/PopCon (alca, db)
@consuegs, @perrotta, @saumyaphor4252, @francescobrivio, @cmsbuild can you please review it and eventually sign? Thanks. @mmusich, @yuanchao, @tocheng, @PonIlya, @rsreds, @JanChyczynski this is something you requested to watch as well. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40206
- This PR adds an extra 20KB to repository
Pull request #44927 was updated. @saumyaphor4252, @perrotta, @francescobrivio, @cmsbuild, @consuegs can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40536
- This PR adds an extra 20KB to repository
Pull request #44927 was updated. @francescobrivio, @saumyaphor4252, @cmsbuild, @consuegs, @perrotta can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40554
- This PR adds an extra 20KB to repository
Pull request #44927 was updated. @saumyaphor4252, @francescobrivio, @consuegs, @perrotta, @cmsbuild can you please check and sign again.
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.
ping (to make bot change milestone)
+1
Successfully used in #45395
Please review and start the tests for this PR
please test
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/42405
Pull request #44927 was updated. @atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please check and sign again.
please test
-1
Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7f8c0/42440/summary.html
COMMIT: e2797717915b511bcc4a28e9c29f865df324d3b5
CMSSW: CMSSW_14_2_X_2024-10-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44927/42440/install.sh to create a dev area with all the needed externals and cmssw changes.
- DAS Queries: The DAS query tests failed, see the summary page for details.
RelVals-INPUT
- 2024.000001
2024.000001_RunJetMET02024D_10k/step1_dasquery.log - 2024.001001
2024.001001_RunZeroBias2024D_10k/step1_dasquery.log - 2024.100001
2024.100001_RunJetMET02024C_10k/step1_dasquery.log
Expand to see more relval errors ...
- 2024.101001
- 2024.000001
- 2024.001001
- 2024.100001
- 2024.101001
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 0 differences found in the comparisons
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3569372
- DQMHistoTests: Total failures: 416
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3568936
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 201 log files, 171 edm output root files, 46 DQM output files
- TriggerResults: no differences found
please test (das errors must be transient)
-1
Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7f8c0/42452/summary.html
COMMIT: e2797717915b511bcc4a28e9c29f865df324d3b5
CMSSW: CMSSW_14_2_X_2024-10-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44927/42452/install.sh to create a dev area with all the needed externals and cmssw changes.
- DAS Queries: The DAS query tests failed, see the summary page for details.
RelVals-INPUT
- 2024.000001
2024.000001_RunJetMET02024D_10k/step1_dasquery.log - 2024.001001
2024.001001_RunZeroBias2024D_10k/step1_dasquery.log - 2024.100001
2024.100001_RunJetMET02024C_10k/step1_dasquery.log
Expand to see more relval errors ...
- 2024.101001
- 2024.000001
- 2024.001001
- 2024.100001
- 2024.101001
Comparison Summary
Summary:
- You potentially removed 2 lines from the logs
- Reco comparison results: 3 differences found in the comparisons
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3569372
- DQMHistoTests: Total failures: 420
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3568932
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 201 log files, 171 edm output root files, 46 DQM output files
- TriggerResults: no differences found
I believe the relval failures are unrelated (failing in other recent PRs as well)
Opened backport to 14_1_X: https://github.com/cms-sw/cmssw/pull/46571
+1
- RelVal failures with das errors are unrelated
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
ignore tests-rejected with ib-failure
+1