cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[DT] Position fix and new filter to TPs from Phase2 L1T emulator

Open jfernan2 opened this issue 1 year ago • 20 comments

PR description:

This PR fixes a bug in the positions retrieved by the DT L1T Phase2 emulator (credits to @javi-llorente ) and applies a coincidence filter to the resulting Trigger Primitives (credits to @dermotmoran )

PR validation:

Talks explaining the problem and supporting this change:

Report from J. F de Troconiz: AM v2 Emulator Global Phi / Phi_B Assignment https://indico.cern.ch/event/1416436/contributions/5953406/attachments/2857442/4999143/DT_TS_Ph2_24_may.pdf

Coincidence filter by D. Moran: https://indico.cern.ch/event/1425784/contributions/5998104/attachments/2876917/5038456/dt_co.pdf

jfernan2 avatar May 08 '24 06:05 jfernan2

cms-bot internal usage

cmsbuild avatar May 08 '24 06:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40199

  • This PR adds an extra 36KB to repository

cmsbuild avatar May 08 '24 06:05 cmsbuild

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

  • L1Trigger/DTTriggerPhase2 (upgrade, l1)

@aloeliger, @epalencia, @srimanob, @subirsarkar, @cmsbuild can you please review it and eventually sign? Thanks. @battibass, @Martin-Grunewald, @missirol, @JanFSchulte this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 08 '24 06:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40202

  • This PR adds an extra 36KB to repository

cmsbuild avatar May 08 '24 10:05 cmsbuild

Pull request #44924 was updated. @srimanob, @subirsarkar, @aloeliger, @epalencia, @cmsbuild can you please check and sign again.

cmsbuild avatar May 08 '24 10:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40223

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40223/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40223/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 10 '24 14:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40239

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40239/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40239/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 13 '24 17:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40240

  • This PR adds an extra 32KB to repository

cmsbuild avatar May 13 '24 17:05 cmsbuild

Pull request #44924 was updated. @aloeliger, @subirsarkar, @cmsbuild, @epalencia, @srimanob can you please check and sign again.

cmsbuild avatar May 13 '24 17:05 cmsbuild

please test

jfernan2 avatar May 20 '24 17:05 jfernan2

-1

Failed Tests: ClangBuild Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc4141/39436/summary.html COMMIT: 9c1e293abdfde56d854af800d912b474517e4264 CMSSW: CMSSW_14_1_X_2024-05-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44924/39436/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'


>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package L1Trigger/DTTriggerPhase2
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-05-20-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-05-20-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package L1Trigger/DTTriggerPhase2
Entering library rule at src/L1Trigger/DTTriggerPhase2/plugins
>> Compiling edm plugin src/L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc

cmsbuild avatar May 20 '24 17:05 cmsbuild

please test

jfernan2 avatar May 22 '24 09:05 jfernan2

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40298

  • This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40298/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40298/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 22 '24 09:05 cmsbuild

please test

jfernan2 avatar May 22 '24 09:05 jfernan2

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40299

  • This PR adds an extra 24KB to repository

cmsbuild avatar May 22 '24 09:05 cmsbuild

Pull request #44924 was updated. @srimanob, @subirsarkar, @epalencia, @aloeliger can you please check and sign again.

cmsbuild avatar May 22 '24 09:05 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc4141/39467/summary.html COMMIT: 4a413a6a391948342bd29617a14cab1617b35395 CMSSW: CMSSW_14_1_X_2024-05-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44924/39467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar May 22 '24 12:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40568

  • This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40568/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40568/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Jun 13 '24 09:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40569

  • This PR adds an extra 56KB to repository

cmsbuild avatar Jun 13 '24 10:06 cmsbuild

Pull request #44924 was updated. @epalencia, @cmsbuild, @aloeliger, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild avatar Jun 13 '24 10:06 cmsbuild

please test

jfernan2 avatar Jul 09 '24 08:07 jfernan2

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc4141/40293/summary.html COMMIT: 26adbdaa6b3db5e39e6c9e4e869bca85d07668fd CMSSW: CMSSW_14_1_X_2024-07-08-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44924/40293/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline: 29634.911 step 2 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 12 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246793
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246770
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 09 '24 12:07 cmsbuild

@cms-sw/l1-l2 the PR is finally ready for review, thanks for your patience

jfernan2 avatar Jul 11 '24 08:07 jfernan2

+l1

aloeliger avatar Jul 23 '24 08:07 aloeliger

@cmsbuild please test

srimanob avatar Aug 14 '24 17:08 srimanob

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc4141/40926/summary.html COMMIT: 26adbdaa6b3db5e39e6c9e4e869bca85d07668fd CMSSW: CMSSW_14_1_X_2024-08-14-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44924/40926/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422510
  • DQMHistoTests: Total failures: 71
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422419
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 2 / 43 workflows

cmsbuild avatar Aug 14 '24 20:08 cmsbuild

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

cmsbuild avatar Aug 27 '24 08:08 cmsbuild

@cms-sw/upgrade-l2 just a ping on the signature

aloeliger avatar Aug 29 '24 14:08 aloeliger

@srimanob can you sign this pr please?

jfernan2 avatar Sep 03 '24 08:09 jfernan2

+Upgrade

srimanob avatar Sep 03 '24 09:09 srimanob