cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Phase2-sim156Z Modify the scripts in Validation/HGCalValidation for all new scenarios

Open bsunanda opened this issue 1 year ago • 10 comments

PR description:

Modify the scripts in Validation/HGCalValidation for all new scenarios

PR validation:

Tested all the modified scripts for the new scenarios

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Apr 25 '24 05:04 bsunanda

cms-bot internal usage

cmsbuild avatar Apr 25 '24 05:04 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44846/40095

  • This PR adds an extra 28KB to repository

cmsbuild avatar Apr 25 '24 05:04 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)

@nothingface0, @syuvivida, @antoniovagnerini, @tjavaid, @rvenditti, @cmsbuild can you please review it and eventually sign? Thanks. @sethzenz, @cseez, @rovere, @vandreev11, @lecriste, @hatakeyamak, @pfs, @missirol, @apsallid, @youyingli, @lgray this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Apr 25 '24 05:04 cmsbuild

@cmsbuild Please test

bsunanda avatar Apr 25 '24 05:04 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05a5c4/39084/summary.html COMMIT: b6fc5d5f0420485c377925d6de4a6ea1d1e23627 CMSSW: CMSSW_14_1_X_2024-04-24-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44846/39084/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline: 25088.203 step 3 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 63 lines to the logs
  • Reco comparison results: 55 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326929
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326900
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Apr 25 '24 10:04 cmsbuild

@nothingface0, @syuvivida, @antoniovagnerini, @tjavaid, @rvenditti Please approve this PR

bsunanda avatar May 10 '24 13:05 bsunanda

please test

  • triggering for fresh tests

tjavaid avatar May 14 '24 02:05 tjavaid

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05a5c4/39365/summary.html COMMIT: b6fc5d5f0420485c377925d6de4a6ea1d1e23627 CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44846/39365/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3339016
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338993
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 14 '24 05:05 cmsbuild

+1

tjavaid avatar May 15 '24 07:05 tjavaid

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 15 '24 07:05 cmsbuild

+1

rappoccio avatar May 20 '24 14:05 rappoccio