cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

first release of TICLv5

Open felicepantaleo opened this issue 1 year ago • 103 comments

PR description:

This PR introduces a preliminary version 5 of the TICL framework. It does not replace TICL v4 in release yet. It features:

  • A MultiVectorManager to handle transparently more collections of the same type as if it was only one. This is very useful when consuming the results coming from more iterations or linking algorithms
  • Move HGCAL time to local time.
  • Improved TICLCandidate reconstruction and treatment of timing information from MTD, hence improving the matching with tracks.
  • Created a process modifier for ticl_v5 that replaces ticl_v3
  • Split CLUE3D parameters in different areas of the detector
  • Tuning of CLUE3D parameters
  • Introduced plug-in system for trackster-trackster linking
  • Introduced new skeletons trackster-trackster linking algorithm
  • Introduced FastJet trackster-trackster linking
  • Introduced Passthrough trackster-trackster linking
  • Introduced MTD information SoA
  • Introduced local time in MC truth information for SimTracksters and SimTICLCandidate
  • Introduced TICL Graph for holding connections between tracksters needed for upcoming GNN and Leiden algorithms
  • Removed CLUE3DLow step
  • Removed TICL v3.
  • Removed Multiclusters

More info at https://indico.cern.ch/event/1394609/#8-hgcal

PR validation:

Executed several phase 2 workflows with and without the process modifier and verified the TICL validation.

Preliminary performance plots coming soon.

felicepantaleo avatar Apr 19 '24 15:04 felicepantaleo

cms-bot internal usage

cmsbuild avatar Apr 19 '24 15:04 cmsbuild

@AuroraPerego @waredjeb

@cms-sw/hgcal-dpg-l2 @cms-sw/pf-l2

felicepantaleo avatar Apr 19 '24 15:04 felicepantaleo

@cmsbuild please test

felicepantaleo avatar Apr 19 '24 15:04 felicepantaleo

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40021

  • This PR adds an extra 868KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

cmsbuild avatar Apr 19 '24 15:04 cmsbuild

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • Configuration/EventContent (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DataFormats/CaloRecHit (reconstruction)
  • DataFormats/HGCalReco (upgrade, reconstruction)
  • DataFormats/TrackReco (reconstruction)
  • Fireworks/Calo (visualization)
  • HLTrigger/Configuration (hlt)
  • RecoHGCal/Configuration (upgrade, reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)
  • RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
  • RecoMTD/Configuration (upgrade, reconstruction)
  • RecoMTD/TrackExtender (upgrade, reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • SimCalorimetry/HGCalAssociatorProducers (simulation, upgrade)
  • TrackingTools/Configuration (reconstruction)
  • TrackingTools/PatternTools (reconstruction)
  • Validation/Configuration (dqm, simulation)
  • Validation/HGCalValidation (dqm)

@davidlange6, @Dr15Jones, @civanch, @AdrianoDee, @rvenditti, @srimanob, @miquork, @mmusich, @alja, @mandrenguyen, @mdhildreth, @nothingface0, @antoniovilela, @subirsarkar, @syuvivida, @makortel, @jfernan2, @antoniovagnerini, @tjavaid, @fabiocos, @sunilUIET, @Martin-Grunewald, @rappoccio can you please review it and eventually sign? Thanks. @ahinzmann, @cericeci, @argiro, @HuguesBrun, @forthommel, @apsallid, @sameasy, @pfs, @jdolen, @jhgoh, @mmusich, @trocino, @gkasieczka, @slomeo, @alja, @cseez, @abbiendi, @mmarionncern, @VourMa, @bsunanda, @lecriste, @silviodonato, @gpetruc, @GiacomoSguazzoni, @mtosi, @lgray, @Fedespring, @sobhatta, @missirol, @makortel, @dgulhan, @thomreis, @JanFSchulte, @bellan, @andrea21z, @fabiocos, @youyingli, @SohamBhattacharya, @Martin-Grunewald, @VinInn, @CeliaFernandez, @seemasharmafnal, @hatakeyamak, @ReyerBand, @wang0jin, @rovere, @edjtscott, @rchatter, @vandreev11, @rappoccio, @sethzenz this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Apr 19 '24 15:04 cmsbuild

@felicepantaleo I think a bit of history cleanup would be nice.

rovere avatar Apr 19 '24 15:04 rovere

-1

Failed Tests: HeaderConsistency UnitTests RelVals RelVals-INPUT AddOn Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/38967/summary.html COMMIT: 57b897dd1fde343483eeea19d2eebea06b5ad5a9 CMSSW: CMSSW_14_1_X_2024-04-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44785/38967/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 22 errors in the following unit tests:

---> test TestConfigDP_1 had ERRORS
---> test TestConfigDP_5 had ERRORS
---> test TestConfigDP_10 had ERRORS
and more ...

RelVals

  • 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 5.15.1_TTbarFS/step1_TTbarFS.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.174.17_RunMinBias2011A/step2_RunMinBias2011A.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 4.264.26_ZMuSkim2011A/step2_ZMuSkim2011A.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 1 sec (ended on Fri Apr 19 18:39:06 2024) - exit: 256
[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 1 sec (ended on Fri Apr 19 18:39:08 2024) - exit: 256
[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 1 sec (ended on Fri Apr 19 18:39:13 2024) - exit: 256
Expand to see more addon errors ...

cmsbuild avatar Apr 19 '24 16:04 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40022

  • This PR adds an extra 868KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

cmsbuild avatar Apr 19 '24 20:04 cmsbuild

Pull request #44785 was updated. @mdhildreth, @makortel, @srimanob, @Martin-Grunewald, @mmusich, @miquork, @Dr15Jones, @civanch, @antoniovilela, @jfernan2, @AdrianoDee, @mandrenguyen, @antoniovagnerini, @subirsarkar, @alja, @fabiocos, @sunilUIET, @cmsbuild, @tjavaid, @syuvivida, @nothingface0, @rappoccio, @rvenditti, @davidlange6 can you please check and sign again.

cmsbuild avatar Apr 19 '24 20:04 cmsbuild

@cmsbuild please test

rovere avatar Apr 21 '24 08:04 rovere

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/38976/summary.html COMMIT: 2c816a2ab6286c83303ff06b17ecd948600a80da CMSSW: CMSSW_14_1_X_2024-04-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44785/38976/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 22 errors in the following unit tests:

---> test TestConfigDP_1 had ERRORS
---> test TestConfigDP_9 had ERRORS
---> test TestConfigDP_12 had ERRORS
and more ...

RelVals

  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
  • 5.15.1_TTbarFS/step1_TTbarFS.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.174.17_RunMinBias2011A/step2_RunMinBias2011A.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 4.264.26_ZMuSkim2011A/step2_ZMuSkim2011A.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 1 sec (ended on Sun Apr 21 11:48:22 2024) - exit: 256
[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 1 sec (ended on Sun Apr 21 11:48:26 2024) - exit: 256
[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 1 sec (ended on Sun Apr 21 11:48:28 2024) - exit: 256
Expand to see more addon errors ...

cmsbuild avatar Apr 21 '24 10:04 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40028

  • This PR adds an extra 876KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40028/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40028/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Apr 22 '24 09:04 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40029

  • This PR adds an extra 880KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

cmsbuild avatar Apr 22 '24 09:04 cmsbuild

Pull request #44785 was updated. @smuzaffar, @antoniovagnerini, @AdrianoDee, @rvenditti, @jfernan2, @syuvivida, @subirsarkar, @Dr15Jones, @fabiocos, @alja, @civanch, @makortel, @mandrenguyen, @antoniovilela, @Martin-Grunewald, @mmusich, @nothingface0, @sunilUIET, @mdhildreth, @rappoccio, @miquork, @davidlange6, @cmsbuild, @tjavaid, @srimanob can you please check and sign again.

cmsbuild avatar Apr 22 '24 09:04 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40030

  • This PR adds an extra 44KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40030/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40030/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Apr 22 '24 09:04 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40031

  • This PR adds an extra 880KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

cmsbuild avatar Apr 22 '24 10:04 cmsbuild

Pull request #44785 was updated. @nothingface0, @miquork, @syuvivida, @jfernan2, @civanch, @smuzaffar, @rvenditti, @davidlange6, @mandrenguyen, @srimanob, @fabiocos, @antoniovilela, @tjavaid, @Martin-Grunewald, @sunilUIET, @AdrianoDee, @cmsbuild, @alja, @mdhildreth, @mmusich, @makortel, @Dr15Jones, @rappoccio, @antoniovagnerini, @subirsarkar can you please check and sign again.

cmsbuild avatar Apr 22 '24 10:04 cmsbuild

@cmsbuild please test

felicepantaleo avatar Apr 22 '24 10:04 felicepantaleo

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/38988/summary.html COMMIT: 1f7bfe74b28dea1cf976b05c92a9dde3d5d154b6 CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44785/38988/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319826
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 40218.45 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 6703.075 KiB HGCAL/HGCalValidator
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

cmsbuild avatar Apr 22 '24 15:04 cmsbuild

@cmsbuild please test workflow 25288.203,25488.203

felicepantaleo avatar Apr 22 '24 18:04 felicepantaleo

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40048

  • This PR adds an extra 44KB to repository

  • Found files with invalid states:

    • RecoHGCal/TICL/plugins/PFTICLProducerV5.cc:
      • Added: b7339f71d1616a3c3007bed153081bb8a4276b4d
      • Deleted: 57b897dd1fde343483eeea19d2eebea06b5ad5a9
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #43761, #43964, #44576, #44708, #44765
    • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): #44560
    • File RecoHGCal/TICL/python/customiseTICLFromReco.py modified in PR(s): #44560
    • File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): #44560
    • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): #44560
    • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): #44560

cmsbuild avatar Apr 22 '24 18:04 cmsbuild

Pull request #44785 was updated. @jfernan2, @civanch, @srimanob, @fabiocos, @subirsarkar, @mmusich, @miquork, @Dr15Jones, @mandrenguyen, @syuvivida, @davidlange6, @Martin-Grunewald, @antoniovilela, @mdhildreth, @antoniovagnerini, @smuzaffar, @alja, @sunilUIET, @tjavaid, @rappoccio, @nothingface0, @rvenditti, @AdrianoDee, @makortel can you please check and sign again.

cmsbuild avatar Apr 22 '24 18:04 cmsbuild

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/39006/summary.html COMMIT: 6bbc0b5e034c0ce3b729fb5cf5209a1c8707d376 CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44785/39006/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 25288.203, 25488.203

cmsbuild avatar Apr 22 '24 21:04 cmsbuild

test parameters:

  • workflow_opts= -w upgrade
  • workflows = 25288.203,25488.203

felicepantaleo avatar Apr 23 '24 05:04 felicepantaleo

@cmsbuild please test

felicepantaleo avatar Apr 23 '24 05:04 felicepantaleo

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/39014/summary.html COMMIT: 6bbc0b5e034c0ce3b729fb5cf5209a1c8707d376 CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44785/39014/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 23-Apr-2024 10:25:57 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

cmsbuild avatar Apr 23 '24 09:04 cmsbuild

let's try with d98

felicepantaleo avatar Apr 23 '24 13:04 felicepantaleo

test parameters:

  • workflow_opts= -w upgrade
  • workflows = 24888.203,25088.203

felicepantaleo avatar Apr 23 '24 13:04 felicepantaleo

@cmsbuild please test

felicepantaleo avatar Apr 23 '24 13:04 felicepantaleo

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/39034/summary.html COMMIT: 6bbc0b5e034c0ce3b729fb5cf5209a1c8707d376 CMSSW: CMSSW_14_1_X_2024-04-23-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44785/39034/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

  • 25088.203A fatal system signal has occurred: segmentation violation

cmsbuild avatar Apr 23 '24 18:04 cmsbuild