CaloParticles in the barrel for Phase2 and generalization of the LC associators

[brusale]

PR description:

This PR enables the building of the CaloParticles in the barrel for Phase2 and generalizes the LCToCP and LCToSC associators (described here) to be run in the barrel. Also, HGCalRecHitMapProducer has been replaced by RecHitMapProducer that may be used to create a map in the barrel as well. In addition, the associators have been moved to namespace ticl.

PR validation:

Tested on wfs 24896.0, 24900.0, 24834.0 and 224834.0.

@felicepantaleo @rovere

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39702

• This PR adds an extra 420KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): #37507

[cmsbuild]

A new Pull Request was created by @brusale for master.

It involves the following packages:

• DataFormats/HGCRecHit (upgrade, reconstruction)
• RecoHGCal/TICL (upgrade, reconstruction)
• RecoLocalCalo/Configuration (reconstruction)
• RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)
• RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
• SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
• SimCalorimetry/HGCalSimProducers (upgrade, simulation)
• SimDataFormats/Associations (simulation)
• SimDataFormats/CaloAnalysis (simulation)
• SimGeneral/MixingModule (simulation)
• Validation/HGCalValidation (dqm)

@mandrenguyen, @mdhildreth, @jfernan2, @nothingface0, @srimanob, @subirsarkar, @cmsbuild, @civanch, @antoniovagnerini, @tjavaid, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks. @bsunanda, @rovere, @vandreev11, @makortel, @lgray, @sethzenz, @forthommel, @edjtscott, @rchatter, @youyingli, @thomreis, @slomeo, @pfs, @sobhatta, @fabiocos, @missirol, @wang0jin, @ReyerBand, @argiro, @lecriste, @cseez, @apsallid, @felicepantaleo, @hatakeyamak, @sameasy this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/38465/summary.html COMMIT: 6c4707ddf6f38bed8104e2164d8daa7e0e4b7937 CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44560/38465/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 136.8311136.8311_RunJetHT2017FreMINIAOD/step2_RunJetHT2017FreMINIAOD.log
• 136.7611136.7611_RunJetHT2016EreMINIAOD/step2_RunJetHT2016EreMINIAOD.log
• 136.88811136.88811_RunJetHT2018DreMINIAODUL/step2_RunJetHT2018DreMINIAODUL.log

Expand to see more relval errors ...

• 4.53
• 139.001
• 140.023
• 136.731
• 136.874
• 136.793
• 135.4
• 158.01
• 140.043
• 140.063
• 1306.0
• 9.0
• 25.0
• 1330.0
• 141.042
• 312.0
• 13234.0
• 14034.0
• 141.044
• 14234.0
• 141.046
• 11634.0
• 25202.0
• 12434.0
• 12846.0
• 12834.7
• 12834.0
• 10224.0
• 24900.0
• 24896.0
• 13034.0
• 24834.0
• 23234.0
• 250202.181
• 25034.999
• 24834.911

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
• 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

• 136.76111
• 136.7611
• 136.77211
• 136.7721
• 136.83111
• 136.8311
• 136.88811
• 136.9
• 140.201
• 140.5611
• 140.202
• 158.01
• 159.01
• 1325.51
• 1325.5
• 1325.516
• 1325.5161
• 1325.517
• 1325.518
• 134.0
• 144.6
• 1002.0
• 13234.0
• 13434.0
• 14034.0
• 14234.0

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/38468/summary.html COMMIT: 6c4707ddf6f38bed8104e2164d8daa7e0e4b7937 CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44560/38468/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 136.7611136.7611_RunJetHT2016EreMINIAOD/step2_RunJetHT2016EreMINIAOD.log
• 136.8311136.8311_RunJetHT2017FreMINIAOD/step2_RunJetHT2017FreMINIAOD.log
• 136.88811136.88811_RunJetHT2018DreMINIAODUL/step2_RunJetHT2018DreMINIAODUL.log

Expand to see more relval errors ...

• 4.53
• 139.001
• 140.023
• 136.731
• 136.874
• 136.793
• 135.4
• 158.01
• 140.043
• 140.063
• 1306.0
• 9.0
• 25.0
• 1330.0
• 141.042
• 312.0
• 13234.0
• 14034.0
• 141.044
• 14234.0
• 141.046
• 11634.0
• 25202.0
• 12434.0
• 12846.0
• 12834.0
• 10224.0
• 12834.7
• 24900.0
• 24896.0
• 13034.0
• 24834.0
• 23234.0
• 250202.181
• 25034.999
• 24834.911

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
• 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

• 136.76111
• 136.7611
• 136.77211
• 136.7721
• 136.8311
• 136.83111
• 136.88811
• 136.9
• 140.201
• 140.5611
• 140.202
• 158.01
• 159.01
• 1325.516
• 1325.51
• 1325.5
• 1325.5161
• 1325.517
• 1325.518
• 134.0
• 144.6
• 1002.0
• 13234.0
• 13434.0
• 14034.0
• 14234.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39750

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): #37507

[cmsbuild]

Pull request #44560 was updated. @srimanob, @mdhildreth, @rvenditti, @syuvivida, @nothingface0, @subirsarkar, @cmsbuild, @antoniovagnerini, @mandrenguyen, @tjavaid, @civanch, @jfernan2 can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/38535/summary.html COMMIT: 6ab4a0c7d2340a1c944cac5ef4ed8a8c3936f17a CMSSW: CMSSW_14_1_X_2024-04-01-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44560/38535/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 98 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 267 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297469
• DQMHistoTests: Total failures: 9190
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3288259
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jfernan2]

type hgcal

[jfernan2]

There seem to be duplicated dictionaries: Searching for 'classes_def.xml' in '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-01-2300/src'.

./DataFormats/HGCRecHit/src/classes_def.xml DetId : unordered_map< DetId, constunsigned int > DetId : edm::Wrapper< unordered_map< DetId, constunsigned int > >

[makortel]

Searching for 'classes_def.xml' in '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-01-2300/src'.

./DataFormats/HGCRecHit/src/classes_def.xml DetId : unordered_map< DetId, constunsigned int > DetId : edm::Wrapper< unordered_map< DetId, constunsigned int > >

IIUC the checker is (rightfully) complaining that these dictionaries should be defined in DataFormats/DetId.

[rovere]

Out of curiosity: how many copies of Rechits are introduced by this single PR? @felicepantaleo

[brusale]

Out of curiosity: how many copies of Rechits are introduced by this single PR? @felicepantaleo

Hi Marco! Indeed I am making too many copies of the RecHits collection, I will take care of it. Thanks for pointing it out!

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39987

• This PR adds an extra 396KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): #37507

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39987/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39987/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39988

• This PR adds an extra 488KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): #37507

[cmsbuild]

Pull request #44560 was updated. @mdhildreth, @cmsbuild, @jfernan2, @syuvivida, @mandrenguyen, @civanch, @tjavaid, @subirsarkar, @nothingface0, @antoniovagnerini, @rvenditti, @srimanob can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/38969/summary.html COMMIT: 27029e249117ed60cd7d37a8b6e9a43b9b4be6e5 CMSSW: CMSSW_14_1_X_2024-04-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44560/38969/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 19 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319599
• DQMHistoTests: Total failures: 9200
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3310379
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[tjavaid]

+1

[civanch]

+1

[srimanob]

@cmsbuild please test Just refresh the test after a month. Very sorry to miss this.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/39475/summary.html COMMIT: 27029e249117ed60cd7d37a8b6e9a43b9b4be6e5 CMSSW: CMSSW_14_1_X_2024-05-22-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44560/39475/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 8654
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3330188
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[felicepantaleo]

A kind reminder to merge this, as other PRs need to be rebased on top of these changes and signed again. @antoniovilela @rappoccio @sextonkennedy