cms-sw
Allow storing 2024 geometry in GEMGeometryParsFromDD
PR description:
The GEMGeometryParsFromDDD has a check for the demonstrator which doesn't work for the 2024 geometry. This PR allows the geometry to be dumped properly in order to make a tag.
PR validation:
Dumped the 2024 geometry (with modified version of [1] to load 2024) and checked that it ran over some 2024 data to read out the new GEM chambers (using also the 2024 alignments and channel map). Since it only affects writing the geometry, there should be no visible changes with this PR.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Before submitting your pull requests, make sure you followed this checklist:
- verify that the PR is really intended for the chosen branch
- verify that changes follow CMS Naming, Coding, And Style Rules
- verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44429/39503
- This PR adds an extra 20KB to repository
A new Pull Request was created by @watson-ij for master.
It involves the following packages:
- Geometry/GEMGeometryBuilder (upgrade, geometry)
@makortel, @bsunanda, @srimanob, @subirsarkar, @cmsbuild, @mdhildreth, @Dr15Jones, @civanch can you please review it and eventually sign? Thanks. @fabiocos, @jshlee, @bsunanda, @giovanni-mocellin, @slomeo this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8aae7/38191/summary.html
COMMIT: ad94ff7dab30237b8c905693cfdb497dcfb3de79
CMSSW: CMSSW_14_1_X_2024-03-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44429/38191/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- Reco comparison results: 60 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 1355
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3295994
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
@watson-ij Just to confirm, with this PR, it will work also for 2021 geometry, e.g. when we do legacy processing with future release, it will not cause issue to dump config in all cases.
Hi @srimanob . Yes, the update should not affect the 2021 geometry dumping either. I just checked, and when using GeometryExtended2021_cff the current code will dump out a geometry with the GE1/1 and the one GE2/1 demonstrator, as it should, and GeometryExtended2024_cff gives the 3 GE2/1 chambers.
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
