cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[Backport 13.0.X] Update Pythia Hook for BB4L

Open lauridsj opened this issue 11 months ago • 2 comments

PR description:

This PR backports #44061 , an update to the Pythia Hook for the BB4L matrix element generator that is needed for the new version of BB4L.

PR validation:

Original PR was tested to produce the same output as the previous version on the old bb4l version, and to produce the same output as a standalone implementation received from the authors (see original PR).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44061 to CMSSW 13_0_X, needed for Run 3 2023 MC production.

lauridsj avatar Mar 15 '24 13:03 lauridsj

A new Pull Request was created by @lauridsj for CMSSW_13_0_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@bbilin, @GurpreetSinghChahal, @cmsbuild, @SiewYan, @menglu21, @alberto-sanchez, @mkirsano can you please review it and eventually sign? Thanks. @mkirsano, @alberto-sanchez this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Mar 15 '24 13:03 cmsbuild

cms-bot internal usage

cmsbuild avatar Mar 15 '24 13:03 cmsbuild

@cmsbuild please test

menglu21 avatar Mar 18 '24 11:03 menglu21

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc3ab9/38217/summary.html COMMIT: d1dea9830ef4ea017803a0d38d4134b41b0dea56 CMSSW: CMSSW_13_0_X_2024-03-17-0000/el8_amd64_gcc11 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44421/38217/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Mar 18 '24 15:03 cmsbuild

+1

menglu21 avatar Mar 27 '24 08:03 menglu21

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Mar 27 '24 08:03 cmsbuild

hold

  • This looks like a major change so will need to be discussed at the ORP meeting and signed off by PPD.

rappoccio avatar Apr 01 '24 17:04 rappoccio

Pull request has been put on hold by @rappoccio They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Apr 01 '24 17:04 cmsbuild

@jordan-martins @malbouis could you please have a look

menglu21 avatar Apr 02 '24 15:04 menglu21

@jordan-martins @malbouis thanks for merging the10_6_X one, could you please also signoff this pr

menglu21 avatar Apr 09 '24 08:04 menglu21

Hi @cms-sw/orp-l2, we @cms-sw/ppd-l2 sign this off. Best, PPD

jordan-martins avatar Apr 09 '24 11:04 jordan-martins

unhold

antoniovilela avatar Apr 09 '24 17:04 antoniovilela

+1

antoniovilela avatar Apr 09 '24 17:04 antoniovilela

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

cmsbuild avatar Apr 09 '24 17:04 cmsbuild