cmssw
cmssw copied to clipboard
cms-sw
[Backport 12.4.X] Update Pythia Hook for BB4L
PR description:
This PR backports #44061 , an update to the Pythia Hook for the BB4L matrix element generator that is needed for the new version of BB4L.
PR validation:
Original PR was tested to produce the same output as the previous version on the old bb4l version, and to produce the same output as a standalone implementation received from the authors (see original PR).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44061 to CMSSW 12_4_X, needed for Run 3 2022 MC production.
A new Pull Request was created by @lauridsj for CMSSW_12_4_X.
It involves the following packages:
- GeneratorInterface/Pythia8Interface (generators)
@cmsbuild, @GurpreetSinghChahal, @mkirsano, @SiewYan, @menglu21, @bbilin, @alberto-sanchez can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e6262/38218/summary.html
COMMIT: b71c7161f025a51a048783bc093493e358df5a0f
CMSSW: CMSSW_12_4_X_2024-03-17-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44420/38218/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 10 lines to the logs
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3766083
- DQMHistoTests: Total failures: 13
- DQMHistoTests: Total nulls: 1
- DQMHistoTests: Total successes: 3766047
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
- DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
- Checked 212 log files, 167 edm output root files, 51 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
hold
- This looks like a major change so will need to be discussed at the ORP meeting and signed off by PPD.
Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all
Hi @rappoccio , thanks for reviewing.
I would like to point out here that the large amount of changes shown by github are in large part refactorings - I have replaced the PowhegHooksBB4L.h file that was in CMSSW by a clean - but functionally similar - version provided directly by the BB4L authors. Also, I think it is important to note that this change will only affect MC generation using the BB4L hooks, i.e. only the BB4L samples that we plan to submit once this is merged.
Since GEN L2s have signed off and no other parts of CMSSW are affected, I wanted to ask whether it is really necessary to go to PPD for approval here.
Cheers,
Laurids
@jordan-martins @malbouis thanks for merging the10_6_X one, could you please also signoff this pr
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.