cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

HLT menu development for `14_0_X` (4/N)

Open mmusich opened this issue 11 months ago • 7 comments

backport of https://github.com/cms-sw/cmssw/pull/44415

PR description:

Development of HLT menus for CMSSW_14_0_X (branch CMSSW_14_1_X).

  • This is the PR for 14_0_X: this is the release cycle currently used for Run-3 HLT-menu development.

This version of the GRun HLT menu corresponds to final list of updates to the "V1.0" menu for the 2024 pp data-taking period.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3092 [TSG] Completion of the offline "Special" table and lists of paths for individual special menus [14_0_X]
  • CMSHLT-3099 [BPH] Include L1 seed to Dimuon low pt Jpsi trigger
  • CMSHLT-3101 [Scouting] Storage of raw AK4PFJets in Scouting
  • CMSHLT-3103 [TSG] Undo GRun changes due to CMSHLT-2860 (MinimumBias PD, smart-PS of HLT_ZeroBias in EventDisplay)
  • CMSHLT-3104 [BTV] Migration of MC_PFBTag to ParticleNet
  • CMSHLT-3109 [ECAL/PF] Integrate Alpaka version of ECAL local reco and PFRecHit+PFCluster reco of HBHE RecHits

In addition, the following changes are included:

  • https://github.com/cms-sw/cmssw/commit/9dc11dc177bde898003f469f824b6c4e5fe779ed robustify test_OnlineVsDevTablesConsistency
  • https://github.com/cms-sw/cmssw/commit/1f63ab2386088c37a457d52fe8991e171805a7b0 add Special subtable to DEV / dev cmsDriver tests
  • https://github.com/cms-sw/cmssw/commit/d907983b623b0a5b64da5deef19b12621f125db2 Introduce 2024v1.0 frozen menu and remove 2023v1.2 and related test machinery.
  • https://github.com/cms-sw/cmssw/commit/15e3f3ed06ced89a1ee1f8b75f55931ad891f849 update readme in HLTrigger/Configuration/scripts/utils to CMSSW_14_0_0

PR validation:

TSG Integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of https://github.com/cms-sw/cmssw/pull/44415 to the 2024 production cycle (CMSSW_14_0_X)

mmusich avatar Mar 15 '24 11:03 mmusich

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol, @fabiocos, @silviodonato this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

  • Backported from #44415

cmsbuild avatar Mar 15 '24 11:03 cmsbuild

cms-bot internal usage

cmsbuild avatar Mar 15 '24 11:03 cmsbuild

enable gpu

mmusich avatar Mar 15 '24 11:03 mmusich

@cmsbuild, please test

mmusich avatar Mar 15 '24 11:03 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b4a0f/38159/summary.html COMMIT: 15e3f3ed06ced89a1ee1f8b75f55931ad891f849 CMSSW: CMSSW_14_0_X_2024-03-15-1100/el8_amd64_gcc12 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44416/38159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 72 lines from the logs
  • Reco comparison results: 60 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3336983
  • DQMHistoTests: Total failures: 3344
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3333617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.092 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.156 KiB HLT/Filters
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 7 / 47 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 730
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39010
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Mar 15 '24 14:03 cmsbuild

+hlt

  • changes in TriggerResults: (found differences in 7 / 47 workflows) look compatible with the path versioning bump (due to the creation of the new online menu) and the updates in the GRun table from https://its.cern.ch/jira/browse/CMSHLT-3103.

mmusich avatar Mar 15 '24 14:03 mmusich

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Mar 15 '24 14:03 cmsbuild

+1

  • HLT dump.

antoniovilela avatar Mar 17 '24 14:03 antoniovilela

type hlt-integration

mmusich avatar Mar 19 '24 10:03 mmusich