cmssw
cmssw copied to clipboard
cms-sw
add a python compilation unit test for DQM online clients
PR description:
In preparing https://github.com/cms-sw/cmssw/pull/44384 I noticed that the test coverage of DQM online clients is somewhat poor since the existing unit tests do not contemplate all the possible run keys that can be exercised at P5.
It would be costly in terms of execution time and in terms of storage space (to store the input RAW data / streamer files) to cover all the possible uses cases in a battery of unit tests that actually execute cmsRun of these configurations, but at least they could be compiled to spot obvious configuration problems (as the ones resolved in https://github.com/cms-sw/cmssw/pull/44384).
This is proposed in this PR.
In order to make the new unit test run, some leftover configuration issues have been fixed. I assume they are somehow irrelevant as they pertain to combinations that are probably never run online, but nevertheless to avoid too much ad hoc handling in the test they are fixed here.
PR validation:
The newly added unit tests: scram b runtests_TestDQMOnlineClients-compilation_[*] run fine.
[*] = 'pp_run','pp_run_stage1','cosmic_run','cosmic_run_stage1','hi_run','hpu_run','commissioning_run'
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but if desired it can be backported to CMSSW_14_0_X for data-taking purposes
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39487
- This PR adds an extra 32KB to repository
A new Pull Request was created by @mmusich for master.
It involves the following packages:
- DQM/Integration (dqm)
- DQM/Physics (dqm)
@rvenditti, @syuvivida, @antoniovagnerini, @tjavaid, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks. @ReyerBand, @rappoccio, @thomreis, @threus, @wang0jin, @batinkov, @rchatter, @argiro, @francescobrivio this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39490
- This PR adds an extra 28KB to repository
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39491
- This PR adds an extra 32KB to repository
Pull request #44412 was updated. @nothingface0, @syuvivida, @tjavaid, @rvenditti, @antoniovagnerini, @cmsbuild can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3e405/38161/summary.html
COMMIT: 486b0a740fa517193a3b682ff36f7c0d6cd72e58
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44412/38161/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 94 lines to the logs
- Reco comparison results: 68 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297383
- DQMHistoTests: Total failures: 1361
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3296002
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
- spurious differences seen from unstable WF
12834.7(open issue #39803 ) - P5 tests OK. (thanks @nothingface0 )
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
