cmssw
cmssw copied to clipboard
cms-sw
Use standard file names in DQM/HcalTasks config files
PR description:
Added cfi or cff extensions. This avoids name collision with auto generated files from fillDescriptions.
PR validation:
I used git grep --cached to look for all references in CMSSW to the files and modified them all.
NOTE: to fully comply to our standard file naming conventions, these files should start will lower case letters to correspond to the module labels for the modules the files are defining.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44408/39481
- This PR adds an extra 20KB to repository
A new Pull Request was created by @Dr15Jones for master.
It involves the following packages:
- DQM/HcalTasks (dqm)
- DQM/Integration (dqm)
@tjavaid, @antoniovagnerini, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks. @DryRun, @threus, @abdoulline, @batinkov, @francescobrivio, @bsunanda this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c41c90/38144/summary.html
COMMIT: 22c387ff1fee5d0f26616c78799a488c42f9ca45
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44408/38144/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
The workflows 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 68 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297383
- DQMHistoTests: Total failures: 1361
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3296002
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
@Dr15Jones , could you please create another PR viz. its backport for 14_0_X ? Thanks!
+1
- spurious differences seen from unstable WF
12834.7(open issue #39803 ) - P5 tests OK. Thanks @nothingface0 !
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
