cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

MTD Validation: Characterization of PU contribution in vertices

Open rdelliga opened this issue 11 months ago • 5 comments

PR description:

Plots added to Primary4DVertexValidation.cc to monitor the impact of Pileup in order to compare different vertex reconstruction algorithms. For details see the presentation at https://indico.cern.ch/event/1390639/contributions/5846174/attachments/2816069/4924070/MTD_DPG_March_DelliGatti.pdf Furthermore, EDM_ML_DEBUG from MtdTracksValidation.cc, integrated with pull request #43741, was removed.

PR validation:

Code compilation and production of plots.

rdelliga avatar Mar 14 '24 15:03 rdelliga

cms-bot internal usage

cmsbuild avatar Mar 14 '24 15:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44405/39478

  • This PR adds an extra 64KB to repository

cmsbuild avatar Mar 14 '24 15:03 cmsbuild

A new Pull Request was created by @rdelliga for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @tjavaid, @syuvivida, @nothingface0, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks. @missirol, @fabiocos this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Mar 14 '24 15:03 cmsbuild

please test

fabiocos avatar Mar 14 '24 16:03 fabiocos

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71fe79/38139/summary.html COMMIT: 42b0c6da027009a8d304a669b756367925f8c83e CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44405/38139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 23 lines to the logs
  • Reco comparison results: 62 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 1358
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3296002
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 30.714 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 5.119 KiB MTD/Vertices
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Mar 14 '24 18:03 cmsbuild

@cms-sw/dqm-l2 any comment?

fabiocos avatar Mar 21 '24 08:03 fabiocos

+1

tjavaid avatar Mar 21 '24 10:03 tjavaid

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Mar 21 '24 10:03 cmsbuild

+1

antoniovilela avatar Mar 22 '24 13:03 antoniovilela