cmssw
cmssw copied to clipboard
cms-sw
Change FEStatus flag labels in ECAL DQM
PR description:
This PR changes the flag labels of the FE Status plots in the ECAL DQM plot
- FIFOFULL -> FORCEDFULLSUPP
- FULLL1ADESYNC -> FIFOFULL
PR validation:
PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is the Master PR. Backports are made to 14_0_X in the PR #44404
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44402/39476
- This PR adds an extra 12KB to repository
A new Pull Request was created by @kyungminparkdrums for master.
It involves the following packages:
- DQM/EcalCommon (dqm)
- DQM/EcalMonitorClient (dqm)
- DQM/EcalMonitorTasks (dqm)
@nothingface0, @tjavaid, @syuvivida, @antoniovagnerini, @rvenditti, @cmsbuild can you please review it and eventually sign? Thanks. @thomreis, @ReyerBand, @rchatter, @wang0jin, @argiro this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
-1
Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa370/38140/summary.html
COMMIT: 233a0ae7a7b8e2383f7204a17d5d29640888d45d
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44402/38140/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @iarspider cms-sw/cmssw#44328
- @valsdav cms-sw/cmssw#44354
- @mmusich cms-sw/cmssw#44370
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa370/38140/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa370/38140/git-merge-result
Build
I found compilation error when building:
>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory
19 | #include "onnxruntime/onnxruntime_cxx_api.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory
Clang Build
I found compilation error while trying to compile with clang. Command used:
USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'
>> Entering Package DQM/EcalMonitorClient >> Entering Package DQM/EcalMonitorTasks >> Entering Package PhysicsTools/NanoAOD >> Entering Package PhysicsTools/ONNXRuntime >> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-03-13-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package Alignment/OfflineValidation >> Compiling src/Alignment/OfflineValidation/bin/DMRmerge.cc >> Compiling src/Alignment/OfflineValidation/bin/Options.cc
Hi, the error is unrelated to the changes I've made in the scripts inside the DQM for the PR.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa370/38311/summary.html
COMMIT: 233a0ae7a7b8e2383f7204a17d5d29640888d45d
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44402/38311/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 105 lines to the logs
- Reco comparison results: 43 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297346
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)