[14_0_X backport] Get AXOL1TL model version from menu as of utm v0.12.0

[quinnanm]

PR description:

This is a backport of https://github.com/cms-sw/cmssw/pull/44054 to update the AXOL1TL emulator to be consistent with new utm grammar v0_12_0 and menu as of L1Menu_Collisions2024_v1_0_1_xml. Changes are identical to 44054 See: https://cms-talk.web.cern.ch/t/update-of-the-2024-l1-menu-tag-l1menu-collisions2024-v1-0-1/36759.

PR validation:

This must be tested and merged together with https://github.com/cms-sw/cmsdist/pull/9065 and upcoming backport of https://github.com/cms-sw/cmssw/pull/44389.

Passes basic code formats and checks.

backport of 44054 to 14_0_X

[cmsbuild]

A new Pull Request was created by @quinnanm for CMSSW_14_0_X.

It involves the following packages:

• Configuration/AlCa (alca)
• Configuration/HLT (hlt)
• HLTrigger/Configuration (hlt)
• L1Trigger/L1TGlobal (l1)

@mmusich, @perrotta, @aloeliger, @cmsbuild, @epalencia, @consuegs, @Martin-Grunewald, @saumyaphor4252 can you please review it and eventually sign? Thanks. @missirol, @mmusich, @rsreds, @silviodonato, @Martin-Grunewald, @tocheng, @yuanchao, @fabiocos this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from #44054

[cmsbuild]

cms-bot internal usage

[cmsbuild]

Pull request #44397 was updated. @Martin-Grunewald, @consuegs, @aloeliger, @perrotta, @epalencia, @mmusich, @cmsbuild, @saumyaphor4252 can you please check and sign again.

[Martin-Grunewald]

@perrotta Now that we have this L1T backprt PR, we'd also need the 14_0 backport of your https://github.com/cms-sw/cmssw/pull/44389 .

[perrotta]

@perrotta Now that we have this L1T backprt PR, we'd also need the 14_0 backport of your #44389 .

Here it is: https://github.com/cms-sw/cmssw/pull/44398

[mmusich]

test parameters:

• pull_request = #44398
• pull_request = https://github.com/cms-sw/cmsdist/pull/9065

[mmusich]

@cmsbuild, please test

[perrotta]

backport of https://github.com/cms-sw/cmssw/pull/44054

[mmusich]

backport of https://github.com/cms-sw/cmssw/pull/44054

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220365/38122/summary.html COMMIT: 4c59bdc7e1ecafb0b9c8a2b6f0104c99aad835ea CMSSW: CMSSW_14_0_X_2024-03-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44397/38122/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 12834.0

----- Begin Fatal Exception 14-Mar-2024 10:37:49 CET-----------------------
An exception of category 'ConditionsError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'gtStage2Raw'
   [5] Calling method for module L1TGlobalProducer/'simGtStage2Digis'
Exception Message:
 Error L1T menu version L1Menu_Collisions2024_v1_0_0 is unsupported due to incompatible utm grammar, please use L1Menu_Collisions2024_v1_0_1 or later
----- End Fatal Exception -------------------------------------------------

• 12846.0

----- Begin Fatal Exception 14-Mar-2024 10:38:18 CET-----------------------
An exception of category 'ConditionsError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'gtStage2Raw'
   [5] Calling method for module L1TGlobalProducer/'simGtStage2Digis'
Exception Message:
 Error L1T menu version L1Menu_Collisions2024_v1_0_0 is unsupported due to incompatible utm grammar, please use L1Menu_Collisions2024_v1_0_1 or later
----- End Fatal Exception -------------------------------------------------

• 12834.7

----- Begin Fatal Exception 14-Mar-2024 10:38:30 CET-----------------------
An exception of category 'ConditionsError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'gtStage2Raw'
   [5] Calling method for module L1TGlobalProducer/'simGtStage2Digis'
Exception Message:
 Error L1T menu version L1Menu_Collisions2024_v1_0_0 is unsupported due to incompatible utm grammar, please use L1Menu_Collisions2024_v1_0_1 or later
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 13034.0

RelVals-INPUT

• 12834.012834.0_TTbar_14TeV+2024/step2_TTbar_14TeV+2024.log
• 12861.012861.0_NuGun+2024/step2_NuGun+2024.log
• 12846.012846.0_ZEE_14+2024/step2_ZEE_14+2024.log

Expand to see more relval errors ...

• 12834.7
• 12834.402
• 12834.412
• 13034.0

[mmusich]

test parameters:

• pull_request = #44398
• pull_request = https://github.com/cms-sw/cmsdist/pull/9065

Ok, this syntax is not correct.

[mmusich]

test parameters:

• pull_request = #44398, https://github.com/cms-sw/cmsdist/pull/9065

[mmusich]

@cmsbuild, please test

[cmsbuild]

Pull request #44397 was updated. @consuegs, @aloeliger, @cmsbuild, @saumyaphor4252, @mmusich, @epalencia, @perrotta, @Martin-Grunewald can you please check and sign again.

[aloeliger]

test parameters:

• pull_request = https://github.com/cms-sw/cmssw/pull/44398, https://github.com/cms-sw/cmsdist/pull/9065

[aloeliger]

please test

[quinnanm]

@mmusich Thank you for the suggested changes to HLTrigger/Configuration/python/customizeHLTforCMSSW.py. I committed the suggestions

[mmusich]

test parameters:

why are these commands repeated every time?

[aloeliger]

I don't know if they need to be, but I didn't want to miss them in case they were required.

[mmusich]

I don't know if they need to be, but I didn't want to miss them in case they were required.

the bot doesn't forget them after they are applied, unless they are overridden from a conflicting command.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220365/38135/summary.html COMMIT: 17c96893dbc0fb15e49f383e04a8ca0cbc11a482 CMSSW: CMSSW_14_0_X_2024-03-14-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44397/38135/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich cms-sw/cmssw#44378

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220365/38135/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220365/38135/git-merge-result

Comparison Summary

Summary:

• You potentially added 13 lines to the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346226
• DQMHistoTests: Total failures: 47
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3346157
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: found differences in 2 / 47 workflows

[mmusich]

Now there are differences in the TriggerResults: found differences in 2 / 47 workflows. In both cases it's AXO:

• https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-03-14-1100+220365/61673/triggerResults/141.044_RunJetMET2023D/reHLT.log
• https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-03-14-1100+220365/61673/triggerResults/13034.0_TTbar_14TeV+2024PU/HLT.log

[aloeliger]

Which is truly unexpected and should not be happening. @quinnanm this should be examined. @quinnanm Out of curiosity, was the axo model updated or upgraded at all between 14_0 and 14_1?

[aloeliger]

@caruta Also out of curiosity, have any changes been made in any menus for AXO nominal or Tight thresholds?

[mmusich]

hold

[cmsbuild]

Pull request has been put on hold by @mmusich They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[quinnanm]

the axo model should be v3 for both cases. I can run a test and look closely at the calculated scores in 14_0_X and 14_1_X for the same file and menu now.

[aloeliger]

@eyigitba & @slaurila FYI

[aloeliger]

the axo model should be v3 for both cases. I can run a test and look closely at the calculated scores in 14_0_X and 14_1_X for the same file and menu now.

So, presumably not the AXO scores changing in the workflow. but that should still be checked. Okay. Is it possible the menu change implied here changed thresholds or results or something?

[quinnanm]

would a different menu be associated with 14_0_X other than L1Menu_Collisions2024_v1_0_1.xml, if so which one?