cmssw Fix/update standalone calo barrel egamma objects

PR description:

This PR implements the following fixes and requests for the Phase-2 Calo standalone EGamma objects in the barrel emulator and corresponds to cms-l1t-offline PR https://github.com/cms-l1t-offline/cmssw/pull/1223.

Using built-in unsigned integer types for the data member(s) of the digitized collections, instead of ap_uint types which was causing issues (see https://github.com/cms-sw/cmssw/pull/43872)
Changed label names of output objects to avoid duplicates: see this commit diff.
Updated the definitions of the DigitizedClusterCorrelator data format to match the latest specifications, including the working points for isolation and shower shape, with standalone and looseTk of each (four flags in total). For convenience, added methods to get these flags.
Also added methods in DigitizedClusterCorrelator to get the real eta and phi, realEta() and realPhi().
Fixed a bug in the DigitizedClusterCorrelator initialization where the crystal eta convention was incorrect.

PR validation:

The following checks were performed:

Checked that digitizing error is gone, when process.schedule = cms.Schedule(process.pL1EG, process.end) and keep * are used in conjunction
Checked in an event that the DigitizedClusterCorrelator and DigitizedClusterGT give the same leading clusters (pT, eta, phi, working points in the case of the correlator clusters) as the l1tp2::CaloTowerCollection clusters.

Mar 13 '24 12:03 skkwan

cms-bot internal usage

Mar 13 '24 12:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44390/39451

This PR adds an extra 52KB to repository

Mar 13 '24 12:03 cmsbuild

A new Pull Request was created by @skkwan for master.

It involves the following packages:

DataFormats/L1TCalorimeterPhase2 (upgrade, l1)
L1Trigger/L1CaloTrigger (upgrade, l1)

@cmsbuild, @subirsarkar, @epalencia, @srimanob, @aloeliger can you please review it and eventually sign? Thanks. @missirol, @rovere, @Martin-Grunewald this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Mar 13 '24 12:03 cmsbuild

Please test

Mar 13 '24 14:03 epalencia

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee9952/38101/summary.html COMMIT: 0b3ba9d2290aff5a6ed66784dfbda8754185410a CMSSW: CMSSW_14_1_X_2024-03-12-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44390/38101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 188 lines to the logs
Reco comparison results: 65 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297383
DQMHistoTests: Total failures: 1358
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3296005
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

Mar 13 '24 16:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44390/39528

This PR adds an extra 48KB to repository

Mar 18 '24 15:03 cmsbuild

Pull request #44390 was updated. @subirsarkar, @srimanob, @epalencia, @aloeliger, @cmsbuild can you please check and sign again.

Mar 18 '24 15:03 cmsbuild

Please test

Mar 18 '24 18:03 epalencia

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee9952/38237/summary.html COMMIT: a24865b12eef9833a56cd1435701bda7cd12bdf3 CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44390/38237/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 23 lines from the logs
Reco comparison results: 58 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 1364
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3295985
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

Mar 18 '24 21:03 cmsbuild

+l1

Mar 20 '24 16:03 aloeliger

REMINDER @rappoccio, @antoniovilela, @sextonkennedy: This PR was tested with cms-sw/cmssw#44450, please check if they should be merged together

Mar 25 '24 12:03 cmsbuild

+1

Mar 25 '24 13:03 rappoccio

merge

Mar 25 '24 13:03 rappoccio