cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

PFMet and PuppiMET Branches: Backport to CMSSW_141X

Open wajidalikhan opened this issue 11 months ago • 8 comments

PR description:

wajidalikhan avatar Mar 13 '24 02:03 wajidalikhan

cms-bot internal usage

cmsbuild avatar Mar 13 '24 02:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44383/39444

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File DQM/Physics/python/singleTopDQM_miniAOD_cfi.py modified in PR(s): #44335
    • File DQM/Physics/python/topSingleLeptonDQM_miniAOD_cfi.py modified in PR(s): #44335
    • File DQM/Physics/src/SingleTopTChannelLeptonDQM_miniAOD.cc modified in PR(s): #44335
    • File DQM/Physics/src/TopSingleLeptonDQM_miniAOD.cc modified in PR(s): #44335
    • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): #44316, #44335
    • File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): #44316, #44335
    • File PhysicsTools/PatAlgos/test/corMETFromMiniAOD.py modified in PR(s): #44335

cmsbuild avatar Mar 13 '24 02:03 cmsbuild

A new Pull Request was created by @wajidalikhan for master.

It involves the following packages:

  • DQM/Physics (dqm)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@hqucms, @tjavaid, @vlimant, @nothingface0, @syuvivida, @jfernan2, @cmsbuild, @rvenditti, @antoniovagnerini, @mandrenguyen can you please review it and eventually sign? Thanks. @gkasieczka, @rappoccio, @andrzejnovak, @demuller, @gouskos, @seemasharmafnal, @mbluj, @gpetruc, @azotz, @mariadalfonso, @Senphy, @mmarionncern, @hatakeyamak, @jdamgov, @JyothsnaKomaragiri, @Ming-Yan, @emilbols, @jdolen, @ahinzmann, @AlexDeMoor, @schoef, @AnnikaStein, @nhanvtran this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Mar 13 '24 02:03 cmsbuild

@wajidalikhan I think this is a backport of https://github.com/cms-sw/cmssw/pull/44335, not https://github.com/cms-sw/cmssw/pull/44038. Please update the PR title and description accordingly.

hqucms avatar Mar 13 '24 10:03 hqucms

Hi @hqucms, there are two separate PR going on. this one https://github.com/cms-sw/cmssw/pull/44038 which is about the renaming the nanoAOD branch. While the second one dealing with MiniAOD clean up https://github.com/cms-sw/cmssw/pull/44335 which is still pending, hasn't been merged yet.

wajidalikhan avatar Mar 13 '24 10:03 wajidalikhan

Hi @hqucms, there are two separate PR going on. this one One MiniAOD Clean up , BTW this is still pending, hasn't been merged yet. The other one is dealing with MiniAOD clean up and other one is dealing with renaming or updating MET branches in NanoAOD

Can you please update the PR description though? Please keep the list of PRs explicit rather than hiding the PR#s in hyper-lnks.

mandrenguyen avatar Mar 14 '24 06:03 mandrenguyen

The milestone seems to be set to 14_1_X rather than 14_0_X

mandrenguyen avatar Mar 14 '24 06:03 mandrenguyen

please overhaul this backport (cherry pick the proper commit and make it against 14_0_X) asap @wajidalikhan

vlimant avatar Mar 15 '24 08:03 vlimant

The 14_0_X backport is done in https://github.com/cms-sw/cmssw/pull/44495. @wajidalikhan Can you close this one?

hqucms avatar Mar 20 '24 21:03 hqucms

please close

vlimant avatar Mar 21 '24 00:03 vlimant