cmssw [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel

PR description:

Following up to https://github.com/cms-sw/cms-sw.github.io/pull/118#issuecomment-1989107356, just to see what it would break.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

Mar 11 '24 21:03 mmusich

cms-bot internal usage

Mar 11 '24 21:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44372/39420

This PR adds an extra 992KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/test/stubs/TestOneAnalyzers.cc modified in PR(s): #44271
- File FWCore/Integration/plugins/ProducerWithPSetDesc.cc modified in PR(s): #44363
- File PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTupleOutputModule.cc modified in PR(s): #44328

Mar 11 '24 22:03 cmsbuild

A new Pull Request was created by @mmusich for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins (alca)
CalibTracker/SiStripESProducers (alca)
CalibTracker/StandaloneTrackerTopology (alca)
CommonTools/RecoUtils (analysis)
CondCore/CondHDF5ESSource (db)
CondCore/ESSources (alca, db)
CondFormats/MFObjects (alca)
CondFormats/RecoMuonObjects (alca, db)
CondTools/BeamSpot (alca, db)
CondTools/Ecal (db)
CondTools/RunInfo (db)
DQM/SiStripMonitorHardware (dqm)
DQMServices/FileIO (dqm)
DQMServices/FwkIO (dqm)
DataFormats/Common (core)
DataFormats/DetId (simulation)
DataFormats/FEDRawData (daq)
DataFormats/HLTReco (hlt)
DataFormats/L1Scouting (daq)
DataFormats/L1ScoutingRawData (daq)
DataFormats/L1TGlobal (l1)
DataFormats/Scouting (core)
DataFormats/SiStripCluster (reconstruction)
DetectorDescription/DDCMS (geometry)
EventFilter/HcalRawToDigi (reconstruction)
FWCore/Framework (core)
FWCore/Integration (core)
FWCore/Modules (core)
FWCore/ServiceRegistry (core)
FWCore/Services (core)
GeneratorInterface/GenFilters (generators)
GeneratorInterface/LHEInterface (generators)
Geometry/TrackerGeometryBuilder (geometry)
GeometryReaders/XMLIdealGeometryESSource (geometry)
HLTrigger/HLTanalyzers (hlt)
IOPool/Input (core)
IgTools/IgProf (core)
JetMETCorrections/Modules (reconstruction)
JetMETCorrections/Type1MET (reconstruction)
L1Trigger/L1TCaloLayer1 (l1)
L1Trigger/L1TCalorimeter (l1)
L1Trigger/Phase2L1GT (l1, upgrade)
L1Trigger/Phase2L1ParticleFlow (l1, upgrade)
MagneticField/GeomBuilder (reconstruction)
PhysicsTools/HepMCCandAlgos (analysis)
PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatUtils (reconstruction, xpog)
RecoBTag/Combined (reconstruction)
RecoBTag/ImpactParameter (reconstruction)
RecoBTag/SecondaryVertex (reconstruction)
RecoBTag/SoftLepton (reconstruction)
RecoBTau/JetTagComputer (reconstruction)
RecoEgamma/EgammaElectronAlgos (reconstruction)
RecoEgamma/EgammaTools (reconstruction)
RecoEgamma/ElectronIdentification (reconstruction)
RecoEgamma/PhotonIdentification (reconstruction)
RecoHI/HiCentralityAlgos (reconstruction)
RecoJets/JetProducers (reconstruction)
RecoLocalCalo/CaloTowersCreator (reconstruction)
RecoLocalCalo/Castor (reconstruction)
RecoLocalCalo/EcalRecProducers (reconstruction)
RecoLocalCalo/HcalRecAlgos (reconstruction)
RecoLocalCalo/HcalRecProducers (reconstruction)
RecoLuminosity/LumiProducer (reconstruction)
RecoMuon/DetLayers (reconstruction)
RecoMuon/MuonIdentification (reconstruction)
RecoMuon/TransientTrackingRecHit (reconstruction)
RecoParticleFlow/PFRecHitProducer (reconstruction)
RecoTracker/GeometryESProducer (reconstruction)
RecoTracker/TkNavigation (reconstruction)
SimCalorimetry/EcalTrigPrimProducers (l1)
TopQuarkAnalysis/TopTools (analysis)
TrackingTools/GsfTools (reconstruction)
TrackingTools/GsfTracking (reconstruction)
TrackingTools/KalmanUpdators (reconstruction)
TrackingTools/MaterialEffects (reconstruction)
TrackingTools/TransientTrack (reconstruction)
Validation/HLTrigger (dqm)
Validation/HcalHits (dqm)

@jfernan2, @consuegs, @epalencia, @saumyaphor4252, @rvenditti, @hqucms, @Martin-Grunewald, @smorovic, @mmusich, @civanch, @smuzaffar, @antoniovagnerini, @bsunanda, @mkirsano, @srimanob, @mandrenguyen, @syuvivida, @menglu21, @bbilin, @alberto-sanchez, @vlimant, @SiewYan, @tvami, @mdhildreth, @makortel, @aloeliger, @francescobrivio, @emeschi, @subirsarkar, @nothingface0, @Dr15Jones, @cmsbuild, @GurpreetSinghChahal, @tjavaid, @perrotta can you please review it and eventually sign? Thanks. @fabiocos, @lgray, @alesaggio, @dgulhan, @Ming-Yan, @bsunanda, @JyothsnaKomaragiri, @andrzejnovak, @jazzitup, @Fedespring, @mmarionncern, @namapane, @fwyzard, @wang0jin, @abbiendi, @rociovilar, @emilbols, @schoef, @JanFSchulte, @hatakeyamak, @HuguesBrun, @mtosi, @ram1123, @yetkinyilmaz, @sobhatta, @rsreds, @CeliaFernandez, @a-kapoor, @GiacomoSguazzoni, @vargasa, @tocheng, @andrea21z, @gouskos, @afiqaize, @Martin-Grunewald, @clelange, @Prasant1993, @valsdav, @mkirsano, @silviodonato, @mariadalfonso, @apsallid, @PonIlya, @alberto-sanchez, @AlexDeMoor, @nhanvtran, @missirol, @echabert, @youyingli, @cericeci, @jdolen, @ahinzmann, @kurtejung, @slomeo, @gkasieczka, @demuller, @threus, @robervalwalsh, @trocino, @sroychow, @thomreis, @mandrenguyen, @jdamgov, @battibass, @makortel, @felicepantaleo, @jlidrych, @yuanchao, @VourMa, @abdoulline, @gbenelli, @yslai, @jhgoh, @gpetruc, @sameasy, @AnnikaStein, @VinInn, @mmusich, @jainshilpi, @yenjie, @varuns23, @idebruyn, @venturia, @Sam-Harper, @barvic, @arossi83, @jandrea, @seemasharmafnal, @bellan, @fioriNTU, @wddgit, @argiro, @Senphy, @rovere, @ReyerBand, @rchatter, @rappoccio this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Mar 11 '24 22:03 cmsbuild

@cmsbuild, please test

Mar 12 '24 06:03 mmusich

@cmsbuild, please abort

Mar 12 '24 21:03 mmusich

@cmsbuild, please test

Mar 12 '24 21:03 mmusich

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-510058/38075/summary.html COMMIT: 2b925001f4934cfdfad11dfb8d3f23f95291abbd CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44372/38075/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

function for each template instantiation.
3. This can also happen when there is an inheritance heirarchy and multiple plugin modules
are defined using derived classes and the base class which share the same fillDescriptions
function. Fix these by redefining the fillDescriptions function in each derived class.
----- End Fatal Exception -------------------------------------------------
gmake: *** [lib/el8_amd64_gcc12/FWCoreIntegrationTestPSet.edmplugin] Error 1
Entering library rule at src/FWCore/Integration/plugins
>> Compiling edm plugin src/FWCore/Integration/plugins/DetSetVectorThingProducer.cc
>> Compiling edm plugin src/FWCore/Integration/plugins/PutOrMergeTestSource.cc
>> Compiling edm plugin src/FWCore/Integration/plugins/SlimmingDSVThingProducer.cc
>> Compiling edm plugin src/FWCore/Integration/plugins/TestGetByLabelAnalyzer.cc

Mar 12 '24 23:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44372/39477

This PR adds an extra 664KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Integration/plugins/ProducerWithPSetDesc.cc modified in PR(s): #44363

Mar 14 '24 14:03 cmsbuild

Pull request #44372 was updated. @vlimant, @mmusich, @Dr15Jones, @smorovic, @emeschi, @menglu21, @mdhildreth, @bbilin, @Martin-Grunewald, @saumyaphor4252, @tvami, @SiewYan, @antoniovagnerini, @jfernan2, @epalencia, @GurpreetSinghChahal, @consuegs, @subirsarkar, @hqucms, @alberto-sanchez, @makortel, @bsunanda, @nothingface0, @aloeliger, @rvenditti, @syuvivida, @srimanob, @mkirsano, @civanch, @francescobrivio, @smuzaffar, @perrotta, @tjavaid, @cmsbuild, @mandrenguyen can you please check and sign again.

Mar 14 '24 14:03 cmsbuild

@cmsbuild, please test

Mar 14 '24 14:03 mmusich

-1

Failed Tests: Build HeaderConsistency ClangBuild Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-510058/38137/summary.html COMMIT: 437ab444c9edc098a65cd8a0e31eb12101a7ef46 CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44372/38137/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@iarspider cms-sw/cmssw#44328
@valsdav cms-sw/cmssw#44354
@mmusich cms-sw/cmssw#44370

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-510058/38137/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-510058/38137/git-merge-result

Build

I found compilation error when building:

>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory
   19 | #include "onnxruntime/onnxruntime_cxx_api.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package TrackingTools/MaterialEffects
>> Entering Package TrackingTools/TransientTrack
>> Entering Package Validation/HLTrigger
>> Entering Package Validation/HcalHits
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-03-13-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/OfflineValidation
>> Compiling  src/Alignment/OfflineValidation/bin/Options.cc
>> Compiling  src/Alignment/OfflineValidation/bin/DMRmerge.cc

Mar 14 '24 15:03 cmsbuild

@cmsbuild, please test

Mar 15 '24 08:03 mmusich

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-510058/38148/summary.html COMMIT: 437ab444c9edc098a65cd8a0e31eb12101a7ef46 CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44372/38148/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

function for each template instantiation.
3. This can also happen when there is an inheritance heirarchy and multiple plugin modules
are defined using derived classes and the base class which share the same fillDescriptions
function. Fix these by redefining the fillDescriptions function in each derived class.
----- End Fatal Exception -------------------------------------------------
gmake: *** [lib/el8_amd64_gcc12/FWCoreIntegrationTestPSet.edmplugin] Error 1
Entering library rule at src/FWCore/Integration/plugins
>> Compiling edm plugin src/FWCore/Integration/plugins/DetSetVectorThingProducer.cc
>> Compiling edm plugin src/FWCore/Integration/plugins/PutOrMergeTestSource.cc
>> Compiling edm plugin src/FWCore/Integration/plugins/SlimmingDSVThingProducer.cc
>> Compiling edm plugin src/FWCore/Integration/plugins/TestGetByLabelAnalyzer.cc

Mar 15 '24 09:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44372/39494

This PR adds an extra 992KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Integration/plugins/ProducerWithPSetDesc.cc modified in PR(s): #44363

Mar 15 '24 13:03 cmsbuild

Pull request #44372 was updated. @mandrenguyen, @mmusich, @epalencia, @Martin-Grunewald, @emeschi, @SiewYan, @GurpreetSinghChahal, @srimanob, @antoniovagnerini, @rvenditti, @perrotta, @alberto-sanchez, @makortel, @aloeliger, @mdhildreth, @cmsbuild, @jfernan2, @Dr15Jones, @tvami, @subirsarkar, @francescobrivio, @smuzaffar, @vlimant, @syuvivida, @hqucms, @mkirsano, @menglu21, @bsunanda, @consuegs, @smorovic, @civanch, @tjavaid, @saumyaphor4252, @bbilin, @nothingface0 can you please check and sign again.

Mar 15 '24 13:03 cmsbuild

@cmsbuild, please test

Mar 15 '24 13:03 mmusich

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-510058/38166/summary.html COMMIT: 0d71279ae897622b9f3b807a46087992512b5523 CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44372/38166/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreIntegrationNoEndPathStatus had ERRORS

Comparison Summary

Summary:

You potentially added 87 lines to the logs
Reco comparison results: 66 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297383
DQMHistoTests: Total failures: 1361
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3296002
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

Mar 15 '24 17:03 cmsbuild

maybe we could achieve this migration by directory instead of doing all at once? I suggest turning this into an issue, and track what subsystem do make the change

Mar 29 '24 12:03 vlimant

-xpog

Mar 29 '24 12:03 vlimant

-reconstruction

Jun 25 '24 13:06 mandrenguyen

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44372/40713

This PR adds an extra 996KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Phase2L1GT/plugins/L1GTBoardWriter.cc modified in PR(s): #44995
- File L1Trigger/Phase2L1GT/plugins/L1GTNTupleProducer.cc modified in PR(s): #44995

Jun 25 '24 13:06 cmsbuild

Pull request #44372 was updated. @rvenditti, @alberto-sanchez, @emeschi, @mdhildreth, @antoniovagnerini, @Dr15Jones, @nothingface0, @aloeliger, @mmusich, @civanch, @epalencia, @Martin-Grunewald, @tjavaid, @srimanob, @bbilin, @perrotta, @smuzaffar, @saumyaphor4252, @SiewYan, @smorovic, @syuvivida, @GurpreetSinghChahal, @bsunanda, @mkirsano, @consuegs, @cmsbuild, @francescobrivio, @tvami, @makortel, @subirsarkar, @menglu21 can you please check and sign again.

Jun 25 '24 13:06 cmsbuild

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

Aug 27 '24 08:08 cmsbuild

cmssw cmssw copied to clipboard

[RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Build

Build

Clang Build

Build

Unit Tests

Comparison Summary

cmssw
cmssw copied to clipboard