cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Generated cfi files can now use new module syntax

Open Dr15Jones opened this issue 1 year ago • 20 comments

PR description:

  • new syntax used if there is an unambiguous default description.
  • possibly ambiguous parts of a default description require explicit types to be used.

PR validation:

Framework code and framework unit tests pass.

Dr15Jones avatar Mar 10 '24 22:03 Dr15Jones

cms-bot internal usage

cmsbuild avatar Mar 10 '24 22:03 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39410

  • This PR adds an extra 132KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39410/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39410/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Mar 10 '24 22:03 cmsbuild

please test

Dr15Jones avatar Mar 10 '24 22:03 Dr15Jones

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39411

  • This PR adds an extra 132KB to repository

cmsbuild avatar Mar 10 '24 22:03 cmsbuild

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Integration (core)
  • FWCore/ParameterSet (core)

@smuzaffar, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks. @missirol, @makortel, @wddgit this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Mar 10 '24 22:03 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/38026/summary.html COMMIT: daf4f676851c1967e9bef0895ad8c23e12e10ce6 CMSSW: CMSSW_14_1_X_2024-03-10-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44363/38026/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19191 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 66 log files, 0 edm output root files, 1 DQM output files

cmsbuild avatar Mar 11 '24 10:03 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39815

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39815/cms-checkout-topic.log

cmsbuild avatar Apr 04 '24 19:04 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39816

  • This PR adds an extra 68KB to repository

cmsbuild avatar Apr 04 '24 20:04 cmsbuild

Pull request #44363 was updated. @smuzaffar, @cmsbuild, @Dr15Jones, @makortel can you please check and sign again.

cmsbuild avatar Apr 04 '24 20:04 cmsbuild

please test

Dr15Jones avatar Apr 04 '24 20:04 Dr15Jones

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/38611/summary.html COMMIT: 24bce5575def42838fff185f5c80be25ac159a7a CMSSW: CMSSW_14_1_X_2024-04-04-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44363/38611/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @mmusich cms-sw/cmssw#44589
  • @saumyaphor4252 cms-sw/cmssw#44594
  • @swagata87 cms-sw/cmssw#44592

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/38611/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/38611/git-merge-result

Build

I found compilation error when building:

>> Done generating edm plugin poisoned information
gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1974: CompilePython] Error 1
>> Plugins of all types refreshed.
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-04-1100'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1860: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-04-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package CondCore/AlignmentPlugins

cmsbuild avatar Apr 04 '24 23:04 cmsbuild

please test

Dr15Jones avatar May 10 '24 13:05 Dr15Jones

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/39336/summary.html COMMIT: 24bce5575def42838fff185f5c80be25ac159a7a CMSSW: CMSSW_14_1_X_2024-05-09-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44363/39336/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Done generating edm plugin poisoned information
gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1995: CompilePython] Error 1
>> Plugins of all types refreshed.
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-05-09-2300'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1881: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-05-09-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package FWCore/Integration

cmsbuild avatar May 10 '24 15:05 cmsbuild

please test

Dr15Jones avatar May 14 '24 13:05 Dr15Jones

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/40252

  • This PR adds an extra 136KB to repository

cmsbuild avatar May 14 '24 13:05 cmsbuild

Pull request #44363 was updated. @makortel, @Dr15Jones, @smuzaffar can you please check and sign again.

cmsbuild avatar May 14 '24 13:05 cmsbuild

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/39376/summary.html COMMIT: 0ce73743f157b896dbd84998cd8a43944fb18809 CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44363/39376/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3339016
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338996
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 14 '24 19:05 cmsbuild

The failure was unrelated to this PR and stemmed from a remote file failing to be opened:

----- Begin Fatal Exception 14-May-2024 19:21:25 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=fad12701-c22c-46f6-a8b6-5800a47b3419
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Dr15Jones avatar May 14 '24 20:05 Dr15Jones

+core

makortel avatar May 16 '24 21:05 makortel

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 16 '24 21:05 cmsbuild

please test

  • Trying again, seems transient.

rappoccio avatar May 20 '24 14:05 rappoccio

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/39434/summary.html COMMIT: 0ce73743f157b896dbd84998cd8a43944fb18809 CMSSW: CMSSW_14_1_X_2024-05-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44363/39434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338944
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 20 '24 20:05 cmsbuild

+1

rappoccio avatar May 22 '24 15:05 rappoccio