cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

Tau spring24 update

Open Duchstf opened this issue 11 months ago • 8 comments

Add changes from https://github.com/cms-l1t-offline/cmssw/pull/1214

Duchstf avatar Mar 07 '24 20:03 Duchstf

cms-bot internal usage

cmsbuild avatar Mar 07 '24 20:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44349/39386

  • This PR adds an extra 28KB to repository

cmsbuild avatar Mar 07 '24 20:03 cmsbuild

A new Pull Request was created by @Duchstf for master.

It involves the following packages:

  • DataFormats/L1TParticleFlow (l1, upgrade)
  • L1Trigger/Phase2L1ParticleFlow (l1, upgrade)

@srimanob, @subirsarkar, @aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks. @missirol, @rovere, @Martin-Grunewald this is something you requested to watch as well. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Mar 07 '24 20:03 cmsbuild

Please test

epalencia avatar Mar 07 '24 20:03 epalencia

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44349/39388

  • This PR adds an extra 28KB to repository

cmsbuild avatar Mar 07 '24 22:03 cmsbuild

Pull request #44349 was updated. @srimanob, @aloeliger, @subirsarkar, @cmsbuild, @epalencia can you please check and sign again.

cmsbuild avatar Mar 07 '24 22:03 cmsbuild

Please test

epalencia avatar Mar 08 '24 06:03 epalencia

@Duchstf, could you add the description for this PR?

epalencia avatar Mar 08 '24 06:03 epalencia

@Duchstf Just another ping on a description for this PR.

aloeliger avatar Mar 18 '24 14:03 aloeliger

@aloeliger Hello, the description is identical to the PR referred above, they are the same changes just now propagating to the master branch!

https://github.com/cms-l1t-offline/cmssw/pull/1214

If you need more detaills let me know, they are identical changes so I didn't write anything else.

Duchstf avatar Mar 18 '24 15:03 Duchstf

@Duchstf I don't know if you have been following, however a large bug in using hls4ml code as emulator code has been discovered (https://github.com/cms-sw/cmssw/issues/44435). Could you comment on how long it might take you to insert namespaces around the weights and typedefs of the phase 2 NN taus?

aloeliger avatar Mar 20 '24 15:03 aloeliger

@aloeliger Hello, thank you for the comment. Just to make sure I understand it, I was just reading the other thread and it looks like the existing naming for the TauNN somehow interferes with the two anomaly detection models?

In either case I'll start working on this asap, but an estimation would be around early next week before I could sit down and add namespaces to everything. I could package it in a separate PR. In the mean time, could this one be merged? since it's already merged in 14_0_0_X?

Duchstf avatar Mar 20 '24 21:03 Duchstf

+l1

  • Phase 2 NN taus will need to namespace itself in the future. Authors are aware of this request.

aloeliger avatar Mar 25 '24 12:03 aloeliger

@aloeliger Has the test been stuck for 2 weeks?

srimanob avatar Mar 25 '24 13:03 srimanob

@cmsbuild please test

srimanob avatar Mar 25 '24 13:03 srimanob

@srimanob Got overzealous clearing out L1 PRs and didn't even notice that. Thanks for catching that.

aloeliger avatar Mar 25 '24 13:03 aloeliger

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01efb/38391/summary.html COMMIT: 784503053250633001491523300153c314550f28 CMSSW: CMSSW_14_1_X_2024-03-25-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44349/38391/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Mar 25 '24 23:03 cmsbuild

+Upgrade

srimanob avatar Apr 06 '24 16:04 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Apr 06 '24 16:04 cmsbuild

@Duchstf @cms-sw/l1-l2 1- Please write a full PR description -- even if you are copying from another repository. 2- Please write meaningful commit messages explaining what is addressed in each commit. You may also squash the commits into a single one [1]. If the squash is done correctly, the PR will not need to be re-signed. Thanks. [1] https://cms-sw.github.io/faq.html#how-do-i-collapse-multiple-commits-into-one https://git-scm.com/book/en/Git-Tools-Rewriting-History N.B. Always create a backup branch. Check locally before (force-)pushing to the PR branch.

antoniovilela avatar Apr 08 '24 12:04 antoniovilela

@antoniovilela Hello!

Thank you, I wrote the PR description again, and squash the commits, please check. Thanks.

Duchstf avatar Apr 10 '24 03:04 Duchstf

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44349/39878

  • This PR adds an extra 12KB to repository

cmsbuild avatar Apr 10 '24 03:04 cmsbuild

Pull request #44349 was updated. can you please check and sign again.

cmsbuild avatar Apr 10 '24 03:04 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01efb/38720/summary.html COMMIT: 3c72e74be28adb92aef1e4a3a8fc0a6b46ad62cf CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44349/38720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 24 lines from the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316240
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

cmsbuild avatar Apr 10 '24 06:04 cmsbuild

+1

antoniovilela avatar Apr 11 '24 17:04 antoniovilela

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01efb/38791/summary.html COMMIT: 3c72e74be28adb92aef1e4a3a8fc0a6b46ad62cf CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44349/38791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline: 546.0 step 2 547.0 step 3 548.0 step 3 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 54 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316234
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

cmsbuild avatar Apr 11 '24 20:04 cmsbuild