Phase2 L1T, Correlator Layer-2 : support emulation of with TMUX18 input + GT interface tweaks

[cerminar]

PR description:

The PR introduces the following changes:

• support pattern file creation for Correlator Layer-2 e/gamma boards with TMUX18 Layer-1 inputs.
• tweak the GT interface, renaming the isolation and quality methods of HW GT object according to the new convention.
• set the charge of non-valid HW GT electron objects to 0.
• address precision of the z0 parameter in TkElectron to have the same precision as in HW

PR validation:

No expected change in performance: changes are only related to interfaces with emulator code.

This is equivalent to: https://github.com/cms-l1t-offline/cmssw/pull/1215

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44346/39380

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @cerminar for master.

It involves the following packages:

• DataFormats/L1TParticleFlow (l1, upgrade)
• L1Trigger/Phase2L1ParticleFlow (l1, upgrade)

@cmsbuild, @subirsarkar, @epalencia, @aloeliger, @srimanob can you please review it and eventually sign? Thanks. @rovere, @missirol, @Martin-Grunewald this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8dd1a4/37968/summary.html COMMIT: 23c73aa0903481768fe0e52df4fc44d41208854d CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44346/37968/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/L1Trigger/Phase2L1GT/plugins/L1GTNTupleProducer.cc
>> Compiling edm plugin src/L1Trigger/Phase2L1GT/plugins/L1GTQuadObjectCond.cc
>> Compiling edm plugin src/L1Trigger/Phase2L1GT/plugins/L1GTSingleObjectCond.cc
>> Compiling edm plugin src/L1Trigger/Phase2L1GT/plugins/L1GTTripleObjectCond.cc
src/L1Trigger/Phase2L1GT/plugins/L1GTProducer.cc: In member function 'void l1t::L1GTProducer::produceCL2Photons(edm::Event&) const':
src/L1Trigger/Phase2L1GT/plugins/L1GTProducer.cc:322:31: error: 'struct l1gt::Photon' has no member named 'isolation'; did you mean 'isolationPT'?
  322 |       gtObj.hwIso_ = gtPhoton.isolation.V.to_int();
      |                               ^~~~~~~~~
      |                               isolationPT
src/L1Trigger/Phase2L1GT/plugins/L1GTProducer.cc:323:32: error: 'struct l1gt::Photon' has no member named 'quality'
  323 |       gtObj.hwQual_ = gtPhoton.quality.V.to_int();

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44346/39394

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #44346 was updated. @aloeliger, @cmsbuild, @srimanob, @epalencia, @subirsarkar can you please check and sign again.

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8dd1a4/38099/summary.html COMMIT: 5192c84f8b7d3ca4ccbae835f687fad6d588be8e CMSSW: CMSSW_14_1_X_2024-03-12-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44346/38099/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[aloeliger]

@cerminar There is a persistent EGamma warning made by these changes that just needs a pair of parens to fix:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-12-2300/src/DataFormats/L1TParticleFlow/interface/egamma.h:171:20: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44346/39458

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #44346 was updated. @epalencia, @cmsbuild, @srimanob, @subirsarkar, @aloeliger can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8dd1a4/38107/summary.html COMMIT: 5b4112a544ca9019e42c52b6ac1863ceb2656d1e CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44346/38107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 85 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297354
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[epalencia]

ping @cms-sw/upgrade-l2

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1