cmssw
cmssw copied to clipboard
cms-sw
add some pixel monitoring elements to per lumisection configuration
PR description:
This pull requests updates the per-lumisection DQMIO configuration file, to add 12 monitoring elements from the pixel tracker to per-lumisection saving (instead of default per-run) in the DQMIO file format.
The names of the newly added monitoring elements are:
• PixelPhase1/Phase1_MechanicalView/PXBarrel/digi_occupancy_per_SignedModuleCoord_per_SignedLadderCoord_PXLayer_[1,2,3,4]
• PixelPhase1/Phase1_MechanicalView/PXForward/digi_occupancy_per_SignedDiskCoord_per_SignedBladePanelCoord_PXRing_[1,2]
• PixelPhase1/Phase1_MechanicalView/PXBarrel/clusters_per_SignedModuleCoord_per_SignedLadderCoord_PXLayer_[1,2,3,4]
• PixelPhase1/Phase1_MechanicalView/PXForward/clusters_per_SignedDiskCoord_per_SignedBladePanelCoord_PXRing_[1,2]
PR validation:
This PR was validated by running the DQMIO production from RAW locally, and the output is as expected. We also checked the impact on the size of the produced DQMIO files, but the impact of adding these monitoring elements is negligible.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is intended for 2024 data taking. A backport to 14_0_X will also be made.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44339/39375
- This PR adds an extra 16KB to repository
A new Pull Request was created by @LukaLambrecht for master.
It involves the following packages:
- DQMServices/Core (dqm)
@syuvivida, @rvenditti, @antoniovagnerini, @tjavaid, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks. @barvic this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
-1
Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a77ac/37977/summary.html
COMMIT: 0e71ae4e2dd528806aabcdbe029b9673fcab214a
CMSSW: CMSSW_14_1_X_2024-03-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44339/37977/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals-INPUT
- 136.749
DAS Error - 136.798
DAS Error - 136.821
DAS Error
Expand to see more relval errors ...
- 136.835
- 136.85
Comparison Summary
Summary:
- You potentially removed 88 lines from the logs
- Reco comparison results: 40 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297383
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297357
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
Hi @tjavaid and @antoniovagnerini (not sure who to tag here). I'm not sure how to make sense of the failed tests. They seem to be just input errors (file reading from DAS) rather than actual code failures, but I don't find any more detailed or clear log messages.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a77ac/38247/summary.html
COMMIT: 0e71ae4e2dd528806aabcdbe029b9673fcab214a
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44339/38247/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 102 lines to the logs
- Reco comparison results: 43 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297346
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
