cmssw
cmssw copied to clipboard
cms-sw
slimmedMETsNoHF and possible cleanup
PR description:
- slimmedMETsNoHF collection in MiniAOD is just MET without considering PF candidates in the HF region
- Its impact on the MiniAOD size is negligible
- it clusters a new CHS jet collection (ak4PFJetsCHSNoHF) which is used for its Type-1 correction consuming a non-negligible CPU time
- No use cases at the moment therefore it can be removed from MiniAOD production workflow
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44335/39368
-
This PR adds an extra 40KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/Physics/src/SingleTopTChannelLeptonDQM_miniAOD.cc modified in PR(s): #44299
- File DQM/Physics/src/TopSingleLeptonDQM_miniAOD.cc modified in PR(s): #44299
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): #44316
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): #44316
A new Pull Request was created by @wajidalikhan for master.
It involves the following packages:
- DQM/Physics (dqm)
- PhysicsTools/PatAlgos (xpog, reconstruction)
@cmsbuild, @rvenditti, @vlimant, @mandrenguyen, @hqucms, @nothingface0, @tjavaid, @jfernan2, @antoniovagnerini, @syuvivida can you please review it and eventually sign? Thanks. @gkasieczka, @jdolen, @demuller, @gouskos, @jdamgov, @azotz, @mariadalfonso, @ahinzmann, @mbluj, @andrzejnovak, @seemasharmafnal, @AnnikaStein, @schoef, @mmarionncern, @rappoccio, @Senphy, @gpetruc, @hatakeyamak, @nhanvtran, @AlexDeMoor, @JyothsnaKomaragiri, @emilbols, @Ming-Yan this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e466d0/37953/summary.html
COMMIT: d6b87f9cb076cf2d6c994f6016cbe6db7827f1c8
CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44335/37953/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 76 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 791 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3293008
- DQMHistoTests: Total failures: 196
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3292792
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
- DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44335/39413
-
This PR adds an extra 16KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): #44316
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): #44316
Pull request #44335 was updated. @cmsbuild, @nothingface0, @tjavaid, @antoniovagnerini, @syuvivida, @rvenditti can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e466d0/38029/summary.html
COMMIT: ec72e4611f6cb1fb285e36a42345086d35a1cb52
CMSSW: CMSSW_14_1_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44335/38029/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 10 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 787 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3296963
- DQMHistoTests: Total failures: 196
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3296747
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
- DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e466d0/38333/summary.html
COMMIT: ec72e4611f6cb1fb285e36a42345086d35a1cb52
CMSSW: CMSSW_14_1_X_2024-03-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44335/38333/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 108 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 791 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3296949
- DQMHistoTests: Total failures: 199
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3296730
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
- DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
