cmssw
cmssw copied to clipboard
cms-sw
Run3 era for 2024 pp reference and UPC reco
PR description:
This PR implements a first version of the Run 3 eras for the 2024 pp reference (at 5.36 TeV) and PbPb UPC reconstruction.
@mandrenguyen
PR validation:
Validated using a minbias sample.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44316/39336
-
This PR adds an extra 40KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): #33532, #43761
A new Pull Request was created by @stahlleiton for master.
It involves the following packages:
- Configuration/Eras (operations)
- Configuration/StandardSequences (operations)
- PhysicsTools/PatAlgos (reconstruction, xpog)
- RecoJets/Configuration (reconstruction)
@antoniovilela, @rappoccio, @vlimant, @fabiocos, @hqucms, @mandrenguyen, @davidlange6, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks. @demuller, @JanFSchulte, @AlexDeMoor, @AnnikaStein, @Ming-Yan, @mmarionncern, @andrzejnovak, @makortel, @nhanvtran, @seemasharmafnal, @mariadalfonso, @azotz, @dgulhan, @mtosi, @VinInn, @VourMa, @gkasieczka, @GiacomoSguazzoni, @felicepantaleo, @clelange, @rovere, @hatakeyamak, @jdamgov, @Martin-Grunewald, @rappoccio, @schoef, @fabiocos, @ahinzmann, @mbluj, @missirol, @Senphy, @gouskos, @mmusich, @gpetruc, @emilbols, @JyothsnaKomaragiri, @slomeo, @sameasy, @jdolen this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
@stahlleiton Normally we add a relVal workflow for testing. Do you want to give it a shot? Can you list the cmsDriver commands you used for testing? I recall that conditions were required for the low pT photon code. Which GT were you using?
For the UPC, the only change was to modify the base era from Run3_2023 to Run3, and I tested it on 13_2_X. To test it in 14_1_X, a new GT will be needed (I can try to request one and add a MC relval for 14_1_X)
Implemented 4 relval MC workflows:
- 149.1: 2024 pp ref
- 180: 2023 Pythia8 gamma-nucleus
- 180.1: 2023 Starlight double diffraction
- 181: 2024 Pythia8 gamma-nucleus
The Pythia8 gamma-nucleus workflows needs the fix implemented in https://github.com/cms-sw/cmssw/pull/44264
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44316/39351
-
This PR adds an extra 112KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): #33532, #43761
Pull request #44316 was updated. @vlimant, @jfernan2, @menglu21, @antoniovilela, @subirsarkar, @GurpreetSinghChahal, @mandrenguyen, @rappoccio, @bbilin, @SiewYan, @fabiocos, @cmsbuild, @srimanob, @davidlange6, @mkirsano, @hqucms, @AdrianoDee, @sunilUIET, @miquork, @alberto-sanchez can you please check and sign again.
-1
Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04bce/37915/summary.html
COMMIT: 14aee38d51d3d146ee146bb07a2a1109f8b3a969
CMSSW: CMSSW_14_1_X_2024-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44316/37915/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals
----- Begin Fatal Exception 06-Mar-2024 09:13:06 CET-----------------------
An exception of category 'Configuration' occurred while
[0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
[1] Calling method for module Pythia8GeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 06-Mar-2024 09:13:06 CET-----------------------
An exception of category 'Configuration' occurred while
[0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
[1] Calling method for module Pythia8GeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------
@AdrianoDee : please include PR https://github.com/cms-sw/cmssw/pull/44264 when submitting the tests with relvals 180 and 181.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04bce/37920/summary.html
COMMIT: 14aee38d51d3d146ee146bb07a2a1109f8b3a969
CMSSW: CMSSW_14_1_X_2024-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44316/37920/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 89 lines to the logs
- Reco comparison results: 47 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3293492
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3293469
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
@stahlleiton I think I'm missing the logic on the wf 181.
Do I understand correctly that this is UPC reco for 2024 with light-by-light settings enabled, but it currently uses the standard pp GT?
Shouldn't that crash due to the lack of photon regression tags in the GT? What am I missing here?
Unless I made a mistake, wf 181 should run the 2023 HI GT in the Reco step (otherwise indeed it should crash if that is not the case)
+reconstruction 2024 UPC will have to be updated when a proper GT is available.
@stahlleiton Just my curiosity, why don't you add also 2024 Starlight double diffraction ?
See noisy on GEN particle validation in both 2023 and 2024. Warning of index mismatch in all events. Should something be update later for validation with gamma-nucleaus generator? Note to @cms-sw/generators-l2
Begin processing the 2nd record. Run 1, Event 2, LumiSection 1 on stream 0 at 06-Mar-2024 11:57:41.246 CET
%MSG-w IncorrectMatching: BasicGenParticleValidation:basicGenParticleValidation 06-Mar-2024 11:57:41 CET Run: 1 Event: 2
Incorrect number of matched indexes: GenParticle = 70 matched indexes = 69
%MSG
Begin processing the 3rd record. Run 1, Event 3, LumiSection 1 on stream 0 at 06-Mar-2024 11:57:42.124 CET
%MSG-w IncorrectMatching: BasicGenParticleValidation:basicGenParticleValidation 06-Mar-2024 11:57:42 CET Run: 1 Event: 3
Incorrect number of matched indexes: GenParticle = 88 matched indexes = 87
%MSG
@stahlleiton Just my curiosity, why don't you add also 2024 Starlight double diffraction ?
Was planning to eventually update the Starlight gridpack with a more recent one (the one used is from 2022) in the near future, so thought of just adding it for 2023 conditions (to test it overall) and then do a follow up PR when the first 2024 HI GTs are available.
@cms-sw/pdmv-l2 , @cms-sw/generators-l2 , @cms-sw/upgrade-l2 : please review/sign this PR
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04bce/38258/summary.html
COMMIT: 14aee38d51d3d146ee146bb07a2a1109f8b3a969
CMSSW: CMSSW_14_1_X_2024-03-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44316/38258/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 92 lines to the logs
- Reco comparison results: 65 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 1358
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3295991
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
@AdrianoDee : thanks for re-triggering the tests. @cms-sw/pdmv-l2 , @cms-sw/generators-l2 , @cms-sw/upgrade-l2 : would be appreciated if you could review/sign this PR, thanks
