cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

adding JME nano in autoNano

Open vlimant opened this issue 11 months ago • 20 comments

PR description:

aiming at having the JME nano configured with NANO:@JME (tagging @nurfikri89 )

PR validation:

new JMEnano workflow ran OK

vlimant avatar Feb 26 '24 13:02 vlimant

cms-bot internal usage

cmsbuild avatar Feb 26 '24 13:02 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39055

  • This PR adds an extra 48KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): #44001
    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #42607
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #42607

cmsbuild avatar Feb 26 '24 13:02 cmsbuild

A new Pull Request was created by @vlimant for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @srimanob, @sunilUIET, @AdrianoDee, @hqucms, @fabiocos, @vlimant, @miquork, @rappoccio, @subirsarkar, @davidlange6, @antoniovilela can you please review it and eventually sign? Thanks. @gpetruc, @makortel, @missirol, @fabiocos, @Martin-Grunewald, @AnnikaStein, @slomeo this is something you requested to watch as well. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Feb 26 '24 13:02 cmsbuild

enable nano

vlimant avatar Feb 26 '24 18:02 vlimant

please test

vlimant avatar Feb 26 '24 18:02 vlimant

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39064

  • This PR adds an extra 44KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): #44001
    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #42607
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #42607

cmsbuild avatar Feb 26 '24 18:02 cmsbuild

Pull request #44087 was updated. @hqucms, @davidlange6, @fabiocos, @antoniovilela, @srimanob, @subirsarkar, @sunilUIET, @miquork, @vlimant, @AdrianoDee, @rappoccio can you please check and sign again.

cmsbuild avatar Feb 26 '24 18:02 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/37697/summary.html COMMIT: d37ba7d401b2f01a0c70fa23f8a32f7a00d3caa7 CMSSW: CMSSW_14_1_X_2024-02-26-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44087/37697/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.402-size.json
  • Nano ERROR: Missing ref/2500.402-size.json | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 2500.0 | 2.551 | 2.551 | 0.000 ( +0.0% ) | 5.23 | 5.27 | -0.7% | 2.133 | 2.226 | | 2500.001 | 2.700 | 2.700 | 0.000 ( +0.0% ) | 4.66 | 4.72 | -1.2% | 2.523 | 2.644 | | 2500.002 | 2.641 | 2.641 | 0.000 ( +0.0% ) | 4.83 | 4.86 | -0.6% | 2.519 | 2.634 | | 2500.01 | 1.322 | 1.322 | 0.000 ( +0.0% ) | 9.52 | 9.72 | -2.0% | 2.203 | 2.245 | | 2500.011 | 1.745 | 1.745 | 0.000 ( +0.0% ) | 5.14 | 5.28 | -2.6% | 2.402 | 2.420 | | 2500.012 | 1.586 | 1.586 | 0.000 ( +0.0% ) | 7.37 | 7.43 | -0.8% | 2.268 | 2.421 | | 2500.1 | 2.194 | 2.194 | 0.000 ( +0.0% ) | 5.25 | 5.32 | -1.4% | 1.962 | 2.060 | | 2500.2 | 2.310 | 2.310 | 0.000 ( +0.0% ) | 6.04 | 6.04 | -0.0% | 1.867 | 1.976 | | 2500.21 | 1.185 | 1.185 | 0.000 ( +0.0% ) | 4.34 | 4.36 | -0.3% | 2.183 | 2.255 | | 2500.211 | 1.549 | 1.549 | 0.000 ( +0.0% ) | 3.75 | 3.74 | +0.1% | 2.223 | 2.331 | | 2500.3 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.55 | 12.66 | -0.8% | 1.875 | 1.958 | | 2500.31 | 1.258 | 1.258 | 0.000 ( +0.0% ) | 19.96 | 20.10 | -0.7% | 2.251 | 2.357 | | 2500.311 | 1.644 | 1.644 | 0.000 ( +0.0% ) | 13.41 | 13.39 | +0.2% | 2.328 | 2.434 | | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.36 | 1.41 | -3.3% | 1.688 | 1.685 | | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.90 | 6.14 | +12.3% | 1.038 | 1.035 | | 2500.314 | 1.157 | 1.157 | 0.000 ( +0.0% ) | 13.99 | 14.16 | -1.2% | 2.176 | 2.175 | | 2500.4 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.33 | 12.54 | -1.7% | 1.888 | 1.926 | | 2500.401 | 1.817 | 1.817 | 0.000 ( +0.0% ) | 10.70 | 10.15 | +5.4% | 1.807 | 1.779 | | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.21 | 1.02 | +17.8% | 1.116 | 1.346 |

cmsbuild avatar Feb 26 '24 23:02 cmsbuild

please test

vlimant avatar Mar 12 '24 13:03 vlimant

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39436

  • This PR adds an extra 56KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #43485, #44263
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #43485

cmsbuild avatar Mar 12 '24 13:03 cmsbuild

Pull request #44087 was updated. @antoniovilela, @davidlange6, @sunilUIET, @miquork, @fabiocos, @hqucms, @subirsarkar, @rappoccio, @vlimant, @srimanob, @AdrianoDee can you please check and sign again.

cmsbuild avatar Mar 12 '24 13:03 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/38061/summary.html COMMIT: 7df4e34db755ab5e92a4e845ce087756c14948a3 CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44087/38061/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 41 log files, 21 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.316-size.json
  • Nano ERROR: Missing ref/2500.316-size.json
  • Nano ERROR: Missing ref/2500.403-size.json
  • Nano ERROR: Missing ref/2500.403-size.json | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.16 | 5.24 | -1.5% | 2.156 | 2.218 | | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.65 | 4.67 | -0.4% | 2.590 | 2.659 | | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.83 | 4.87 | -0.8% | 2.585 | 2.651 | | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.23 | 9.58 | -3.6% | 2.267 | 2.262 | | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.09 | 5.20 | -2.1% | 2.397 | 2.479 | | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.25 | 7.45 | -2.8% | 2.292 | 2.359 | | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.21 | 5.28 | -1.3% | 2.063 | 2.057 | | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 5.93 | 6.05 | -2.0% | 1.970 | 1.974 | | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.31 | 4.32 | -0.3% | 2.257 | 2.260 | | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.63 | 3.75 | -3.4% | 2.221 | 2.338 | | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 11.87 | 12.64 | -6.1% | 1.958 | 1.961 | | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 9.85 | 9.84 | +0.0% | 1.943 | 1.938 | | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 18.61 | 19.93 | -6.6% | 2.352 | 2.331 | | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 12.88 | 13.20 | -2.4% | 2.308 | 2.406 | | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.39 | 1.42 | -2.4% | 1.684 | 1.685 | | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.16 | 6.24 | -1.4% | 1.037 | 1.043 | | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 13.16 | 13.95 | -5.6% | 2.049 | 2.123 | | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 13.21 | 13.69 | -3.5% | 2.312 | 2.311 | | 2500.4 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 11.94 | 12.28 | -2.7% | 1.814 | 1.866 | | 2500.401 | 1.824 | 1.824 | 0.000 ( +0.0% ) | 9.91 | 10.53 | -5.9% | 1.685 | 1.804 | | 2500.402 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 9.36 | 10.04 | -6.8% | 1.910 | 1.874 | | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.02 | 1.16 | -11.9% | 1.083 | 1.124 |

cmsbuild avatar Mar 12 '24 22:03 cmsbuild

+1

vlimant avatar Mar 13 '24 06:03 vlimant

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39445

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #43485
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #43485

cmsbuild avatar Mar 13 '24 07:03 cmsbuild

Pull request #44087 was updated. @davidlange6, @rappoccio, @subirsarkar, @cmsbuild, @fabiocos, @srimanob, @AdrianoDee, @antoniovilela, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Mar 13 '24 07:03 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39456

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): #44368
    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #43485
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #43485, #44391

cmsbuild avatar Mar 13 '24 14:03 cmsbuild

Pull request #44087 was updated. @AdrianoDee, @srimanob, @miquork, @fabiocos, @antoniovilela, @subirsarkar, @cmsbuild, @davidlange6, @rappoccio, @sunilUIET can you please check and sign again.

cmsbuild avatar Mar 13 '24 14:03 cmsbuild

@cms-sw/pdmv-l2 @cms-sw/operations-l2 @cms-sw/upgrade-l2 : can you please sign quickly this trivial PR so that we can get the backport going. it is BTW quite silly that we need 4 signatures on something so trivial … maybe we coud have an OR of L2 signature for pyreleasevalidation ?

vlimant avatar Mar 14 '24 07:03 vlimant

+Upgrade

srimanob avatar Mar 14 '24 09:03 srimanob

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/38126/summary.html COMMIT: 66528c767cdcda7824a5488a023c9bedf4bfb6de CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44087/38126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 95 lines to the logs
  • Reco comparison results: 54 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297354
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 41 log files, 21 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
  • Nano ERROR: Missing ref/2500.404-size.json | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.28 | 5.10 | +3.6% | 2.214 | 2.220 | | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.69 | 4.60 | +2.0% | 2.661 | 2.658 | | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.87 | 4.72 | +3.1% | 2.635 | 2.650 | | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.78 | 9.42 | +3.8% | 2.335 | 2.331 | | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.24 | 5.16 | +1.7% | 2.523 | 2.534 | | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.49 | 7.25 | +3.3% | 2.443 | 2.441 | | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.31 | 5.30 | +0.2% | 2.059 | 2.061 | | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 6.07 | 6.04 | +0.6% | 1.974 | 1.968 | | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.33 | 4.31 | +0.4% | 2.274 | 2.272 | | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.76 | 3.71 | +1.2% | 2.353 | 2.353 | | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.58 | 12.12 | +3.8% | 1.958 | 1.959 | | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.23 | 9.90 | +3.3% | 1.947 | 1.941 | | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 19.66 | 19.43 | +1.2% | 2.356 | 2.357 | | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 13.55 | 13.73 | -1.3% | 2.433 | 2.433 | | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.36 | 1.42 | -3.9% | 1.679 | 1.679 | | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.55 | 6.86 | -4.5% | 1.037 | 1.030 | | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.46 | 14.64 | -1.2% | 2.204 | 2.201 | | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 13.69 | 13.13 | +4.3% | 2.341 | 2.351 | | 2500.316 | 3.091 | 1.787 | 1.304 ( +73.0% ) | 2.26 | 13.18 | -82.9% | 1.969 | 2.350 | | 2500.4 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.67 | 12.39 | +2.3% | 1.963 | 1.965 | | 2500.401 | 1.824 | 1.824 | 0.000 ( +0.0% ) | 10.38 | 9.56 | +8.6% | 1.809 | 1.812 | | 2500.402 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.13 | 9.81 | +3.3% | 1.944 | 1.952 | | 2500.403 | 5.188 | 2.620 | 2.568 ( +98.0% ) | 1.56 | 10.02 | -84.5% | 1.893 | 1.950 | | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.25 | 1.07 | +16.6% | 1.342 | 1.343 |

cmsbuild avatar Mar 14 '24 12:03 cmsbuild

+pdmv

AdrianoDee avatar Mar 17 '24 14:03 AdrianoDee

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/38198/summary.html COMMIT: 66528c767cdcda7824a5488a023c9bedf4bfb6de CMSSW: CMSSW_14_1_X_2024-03-16-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44087/38198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 41 log files, 21 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
  • Nano ERROR: Missing ref/2500.404-size.json | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.17 | 3.32 | +55.4% | 2.213 | 1.911 | | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.65 | 2.98 | +56.1% | 2.602 | 2.337 | | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.82 | 3.11 | +54.8% | 2.597 | 2.330 | | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.68 | 6.30 | +53.7% | 2.283 | 1.997 | | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.23 | 3.44 | +52.0% | 2.446 | 2.192 | | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.35 | 5.00 | +47.0% | 2.419 | 2.099 | | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.21 | 3.34 | +55.8% | 2.064 | 2.055 | | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 6.02 | 3.81 | +58.0% | 1.976 | 1.937 | | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.33 | 2.83 | +52.9% | 2.258 | 1.953 | | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.73 | 2.20 | +69.4% | 2.339 | 2.054 | | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.19 | 7.51 | +62.4% | 1.962 | 1.945 | | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.13 | 5.68 | +78.4% | 1.952 | 1.956 | | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 19.15 | 11.95 | +60.2% | 2.356 | 1.949 | | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 13.46 | 8.02 | +67.8% | 2.413 | 2.040 | | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.39 | 0.89 | +56.2% | 1.706 | 1.706 | | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.02 | 4.61 | +30.8% | 1.052 | 1.056 | | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.11 | 8.13 | +73.6% | 2.055 | 1.760 | | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 13.62 | 8.35 | +63.2% | 2.307 | 2.345 | | 2500.316 | 3.091 | 1.787 | 1.304 ( +73.0% ) | 2.21 | 8.56 | -74.1% | 2.244 | 2.360 | | 2500.4 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.12 | 7.71 | +57.2% | 1.915 | 1.969 | | 2500.401 | 1.824 | 1.824 | 0.000 ( +0.0% ) | 9.87 | 5.85 | +68.7% | 1.700 | 1.809 | | 2500.402 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 9.74 | 5.91 | +64.7% | 1.950 | 1.951 | | 2500.403 | 5.188 | 2.620 | 2.568 ( +98.0% ) | 1.57 | 6.10 | -74.3% | 1.870 | 1.953 | | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.19 | 0.78 | +52.1% | 1.364 | 1.351 |

cmsbuild avatar Mar 17 '24 17:03 cmsbuild

+1

antoniovilela avatar Mar 18 '24 17:03 antoniovilela

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild avatar Mar 18 '24 17:03 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/38236/summary.html COMMIT: 66528c767cdcda7824a5488a023c9bedf4bfb6de CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44087/38236/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 41 log files, 21 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
  • Nano ERROR: Missing ref/2500.404-size.json | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.31 | 5.25 | +1.0% | 2.237 | 2.222 | | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.72 | 4.74 | -0.5% | 2.654 | 2.247 | | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.90 | 4.90 | +0.0% | 2.659 | 2.255 | | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.63 | 9.67 | -0.4% | 2.267 | 2.081 | | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.25 | 5.25 | -0.1% | 2.419 | 2.124 | | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.36 | 7.58 | -2.8% | 2.328 | 2.031 | | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.28 | 5.30 | -0.4% | 2.063 | 2.039 | | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 6.05 | 6.05 | +0.0% | 1.970 | 1.933 | | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.31 | 4.36 | -1.0% | 2.270 | 1.952 | | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.78 | 3.73 | +1.2% | 2.349 | 2.052 | | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.58 | 12.59 | -0.1% | 1.962 | 1.936 | | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.39 | 10.19 | +1.9% | 1.943 | 1.948 | | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 20.12 | 19.85 | +1.3% | 2.347 | 2.338 | | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 13.57 | 13.34 | +1.7% | 2.436 | 2.428 | | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.44 | 1.44 | +0.3% | 1.699 | 1.700 | | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.96 | 5.97 | +16.5% | 1.055 | 1.053 | | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.29 | 14.20 | +0.7% | 2.061 | 1.811 | | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 14.23 | 13.91 | +2.3% | 2.318 | 2.322 | | 2500.316 | 3.091 | 1.787 | 1.304 ( +73.0% ) | 2.26 | 13.45 | -83.2% | 1.974 | 2.219 | | 2500.4 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.49 | 12.53 | -0.3% | 1.842 | 1.852 | | 2500.401 | 1.824 | 1.824 | 0.000 ( +0.0% ) | 10.54 | 10.69 | -1.4% | 1.779 | 1.811 | | 2500.402 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.08 | 10.06 | +0.2% | 1.952 | 1.943 | | 2500.403 | 5.188 | 2.620 | 2.568 ( +98.0% ) | 1.57 | 10.35 | -84.8% | 1.849 | 1.948 | | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.21 | 1.23 | -1.4% | 1.364 | 1.360 |

cmsbuild avatar Mar 18 '24 20:03 cmsbuild

This PR appears to have broken several RelVals in the IB: 10224.15, 11024.15, 11634.15, 25202.15

These died in cmsDriver.py with the error

NANO,DQM:@nanoAODDQM
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
with DB:
entry file:step3_inMINIAODSIM.root
Step: NANO Spec: 
in prepare_nano nanoSequenceMC
Step: DQM Spec: ['@nanoAODDQM']
customising the process with PrepJMECustomNanoAOD_MC from PhysicsTools/NanoAOD/custom_jme_cff
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/bin/el8_amd64_gcc12/cmsDriver.py", line 40, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/bin/el8_amd64_gcc12/cmsDriver.py", line 16, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 2449, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 952, in addCustomise
    raise Exception("config "+f+" has no function "+fcn)
Exception: config PhysicsTools/NanoAOD/custom_jme_cff has no function PrepJMECustomNanoAOD_MC

Dr15Jones avatar Mar 19 '24 08:03 Dr15Jones

#44464 will fix this oversight

vlimant avatar Mar 20 '24 09:03 vlimant