cmssw
cmssw copied to clipboard
cms-sw
HCAL proprietary RelVal machinery update
PR description:
HCAL is using its own RelVal machinery (macros/scripts/html + histos plotting .json files) in Validation/CaloTowers/test/... for publishing RelVal comparison plots produced in an optimized/adjusted way https://cms-docs.web.cern.ch/hcal-sw-validation/?dir=14_0_X And uses RelMon only occasionally for some minimal auxiliary checks, as described in slide#4: https://indico.cern.ch/event/1242712/contributions/5222784/attachments/2578491/4447489/HCAL_Validation_Jan20_2023_S.A.pdf
This is the fist-pass update/cleaning, which comes after ~6 (!) years of using various private modifications of the files from private branches/locations of several involved people.
PR validation:
NB: no any regular wfs is affected.
Private full-fledged test for 14_0_0_pre2 vs pre1 RelVals for both "2023" and Phase2 (aka "2026D98") TTbar
- successful
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38832
- This PR adds an extra 60KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
-
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38832/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38832/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38835
- This PR adds an extra 64KB to repository
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.
It involves the following packages:
- Validation/CaloTowers (dqm)
@cmsbuild, @antoniovagnerini, @syuvivida, @tjavaid, @nothingface0, @rvenditti can you please review it and eventually sign? Thanks. @missirol, @hatakeyamak this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-409ab5/37464/summary.html
COMMIT: 6657a205ad5611aef18f7fd9cbb95e026b4119d9
CMSSW: CMSSW_14_1_X_2024-02-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43953/37464/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 7 lines to the logs
- Reco comparison results: 42 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3248554
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3248529
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 200 log files, 161 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/39301
- This PR adds an extra 64KB to repository
Pull request #43953 was updated. @syuvivida, @antoniovagnerini, @cmsbuild, @tjavaid, @nothingface0, @rvenditti can you please check and sign again.
@tjavaid may this technical /test update be processed and eventually merged?
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-409ab5/38206/summary.html
COMMIT: 61bd4658432984fd243282eb5892c1c51db1d30a
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43953/38206/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 75 lines to the logs
- Reco comparison results: 54 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 9
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297340
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/39564
- This PR adds an extra 64KB to repository
Pull request #43953 was updated. @rvenditti, @nothingface0, @tjavaid, @antoniovagnerini, @cmsbuild, @syuvivida can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-409ab5/38295/summary.html
COMMIT: fb1e348ea2b5da873da6c83eabf0af29de4ee143
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43953/38295/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 3 lines to the logs
- Reco comparison results: 46 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297346
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
