cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

Cell offset and Cell area calculation of partial wafer cells for HGCAL V18

Open bhattlokesh2027 opened this issue 1 year ago • 21 comments

PR description: The cells present along the cut of partial wafer have irregular shape, so PR includes calculation of centroid and area of these cells.

PR validation: This PR is only meant for V18 version of HGCAL with testing script added in the PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bhattlokesh2027 avatar Feb 09 '24 07:02 bhattlokesh2027

cms-bot internal usage

cmsbuild avatar Feb 09 '24 07:02 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43925/38777

  • This PR adds an extra 24KB to repository

cmsbuild avatar Feb 09 '24 07:02 cmsbuild

A new Pull Request was created by @bhattlokesh2027 for master.

It involves the following packages:

  • Geometry/HGCalCommonData (upgrade, geometry)

@cmsbuild, @makortel, @srimanob, @civanch, @subirsarkar, @mdhildreth, @Dr15Jones, @bsunanda can you please review it and eventually sign? Thanks. @fabiocos, @bsunanda this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Feb 09 '24 07:02 cmsbuild

@cmsbuild Please test

bsunanda avatar Feb 09 '24 07:02 bsunanda

-1

Failed Tests: ClangBuild Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd413a/37319/summary.html COMMIT: edbf106aff216591e5b4465005f5f9d3edd4a079 CMSSW: CMSSW_14_1_X_2024-02-08-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43925/37319/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild avatar Feb 09 '24 07:02 cmsbuild

-1

Failed Tests: ClangBuild Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd413a/37319/summary.html COMMIT: edbf106aff216591e5b4465005f5f9d3edd4a079 CMSSW: CMSSW_14_1_X_2024-02-08-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43925/37319/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild avatar Feb 09 '24 07:02 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43925/38794

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43925/38794/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43925/38794/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Feb 11 '24 09:02 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43925/38795

  • This PR adds an extra 24KB to repository

cmsbuild avatar Feb 11 '24 13:02 cmsbuild

Pull request #43925 was updated. @subirsarkar, @bsunanda, @cmsbuild, @srimanob, @civanch, @mdhildreth, @Dr15Jones, @makortel can you please check and sign again.

cmsbuild avatar Feb 11 '24 13:02 cmsbuild

@cmsbuild Please test

bsunanda avatar Feb 11 '24 13:02 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd413a/37343/summary.html COMMIT: 8083787954e55c5f2b8148ed8852004b6891ff9e CMSSW: CMSSW_14_1_X_2024-02-10-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43925/37343/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Feb 11 '24 16:02 cmsbuild

+geometry

bsunanda avatar Feb 12 '24 03:02 bsunanda

@cmsbuild please test with 27234.0

Test should be done on affected geometry, i.e. D104 with C22 (V18 HGCAL).

srimanob avatar Feb 12 '24 07:02 srimanob

@cmsbuild please test with 27234.0

srimanob avatar Feb 14 '24 01:02 srimanob

Hi @smuzaffar It seems the test is never done. Will trigger again help?

srimanob avatar Feb 19 '24 12:02 srimanob

@cmsbuild please test with 27234.0

srimanob avatar Feb 19 '24 12:02 srimanob

@cmsbuild please test with 27234.0

srimanob avatar Mar 05 '24 16:03 srimanob

@smuzaffar @rappoccio @antoniovilela Could you please help to trigger the test as above? I tried several times in past few weeks, and it never work. Thanks.

srimanob avatar Mar 08 '24 14:03 srimanob

@cmsbuild, please test workflow 27234.0

makortel avatar Mar 08 '24 14:03 makortel

@cmsbuild, please test workflow 27234.0

Ah, I use the wrong word. Thanks @makortel

srimanob avatar Mar 08 '24 14:03 srimanob

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd413a/37996/summary.html COMMIT: 8083787954e55c5f2b8148ed8852004b6891ff9e CMSSW: CMSSW_14_1_X_2024-03-08-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43925/37996/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Mar 08 '24 20:03 cmsbuild

@cmsbuild, please test workflow 27234.0

srimanob avatar Mar 20 '24 14:03 srimanob

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd413a/38302/summary.html COMMIT: 8083787954e55c5f2b8148ed8852004b6891ff9e CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43925/38302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Mar 20 '24 18:03 cmsbuild

@srimonab Please sign this

bsunanda avatar Mar 26 '24 10:03 bsunanda

+Upgrade

srimanob avatar Mar 26 '24 10:03 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Mar 26 '24 10:03 cmsbuild

@bhattlokesh2027 Please write meaningful commit messages explaining what is addressed in each commit. You may also squash the commits into a single one [1]. If the squash is done correctly, the PR will not need to be re-signed. Thanks.

[1] https://cms-sw.github.io/faq.html#how-do-i-collapse-multiple-commits-into-one https://git-scm.com/book/en/Git-Tools-Rewriting-History N.B. Always create a backup branch. Check locally before (force-)pushing to the PR branch.

antoniovilela avatar Mar 26 '24 14:03 antoniovilela

@bhattlokesh2027 ping

antoniovilela avatar Apr 04 '24 23:04 antoniovilela

Extremely sorry for the late reply and bad commit messages. Should I use " git reset " and " git commit --amend " or should I use the " git rebase -i " command to avoid resign.

bhattlokesh2027 avatar Apr 05 '24 07:04 bhattlokesh2027

I believe you make your comments in the git page and do not change the code in the repository.

From: bhattlokesh2027 @.> Sent: 05 April 2024 12:31 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Cell offset and Cell area calculation of partial wafer cells for HGCAL V18 (PR #43925)

Extremely sorry for the late reply and bad commit messages. Should I use " git reset " and " git commit --amend " or should I use the " git rebase -i " command to avoid resign.

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/43925#issuecomment-2039094119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOXSSSJUTKSLG5II2ZTY3ZD4HAVCNFSM6AAAAABDA7RVDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGA4TIMJRHE. You are receiving this because you were mentioned.Message ID: @.***>

bsunanda avatar Apr 05 '24 07:04 bsunanda