cms-sw
Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content
This PR adds a new collection to the phase-2 L1 event content.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
As for https://github.com/cms-sw/cmssw/pull/43869, we are sort of hoping for this content to make it into the scheduled HLT MC production for CMSSW_14_0. Therefore, this PR may need to be backported based on whether or not it can be quickly included in the final build of CMSSW_14_0.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43872/38723
-
This PR adds an extra 16KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): #42840, #43633, #43869
A new Pull Request was created by @epalencia (Enrique Palencia Cortezon) for master.
It involves the following packages:
- L1Trigger/Configuration (l1)
@cmsbuild, @epalencia, @aloeliger can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
-1
Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/37226/summary.html
COMMIT: 5c62e9409e383c23b7b6c1fb5d1307bfc688846b
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43872/37226/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals
----- Begin Fatal Exception 05-Feb-2024 19:00:30 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Additional Info:
[a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Feb-2024 19:01:00 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Additional Info:
[a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Feb-2024 19:04:28 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Additional Info:
[a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved
----- End Fatal Exception -------------------------------------------------
RelVals-INPUT
- 24034.0
24034.0_TTbar_14TeV+2026D96/step2_TTbar_14TeV+2026D96.log - 24834.0
24834.0_TTbar_14TeV+2026D98/step2_TTbar_14TeV+2026D98.log - 20834.0
20834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
Expand to see more relval errors ...
-1
Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/37229/summary.html
COMMIT: 5c62e9409e383c23b7b6c1fb5d1307bfc688846b
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43872/37229/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals
----- Begin Fatal Exception 05-Feb-2024 21:06:59 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Additional Info:
[a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Feb-2024 21:07:32 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Additional Info:
[a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Feb-2024 21:10:23 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Additional Info:
[a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved
----- End Fatal Exception -------------------------------------------------
RelVals-INPUT
- 24034.0
24034.0_TTbar_14TeV+2026D96/step2_TTbar_14TeV+2026D96.log - 20834.0
20834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log - 24834.0
24834.0_TTbar_14TeV+2026D98/step2_TTbar_14TeV+2026D98.log
Expand to see more relval errors ...
Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.
@skkwan @pallabidas What is the status of a fix for serializing Calo EGamma objects? I am going through today and trying to un-stick L1T PRs and finalize them. Are we ready to retest adding these objects to event content?
@aloeliger @pallabidas We have a fix tested locally that serializes the Calo EGamma objects without errors. We will submit a PR ASAP, only pending one or two changes to the data format of the clusters send to the Correlators that will provide them with the quality bits they need to use.
-1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/38134/summary.html
COMMIT: 5c62e9409e383c23b7b6c1fb5d1307bfc688846b
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43872/38134/install.sh to create a dev area with all the needed externals and cmssw changes.
This pull request cannot be automatically merged, could you please rebase it? You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/38134/git-merge-result
Oh, not even paying attention. @epalencia Could you rebase this when you get the chance?
I'm closing this PR, superseeded by https://github.com/cms-sw/cmssw/pull/44450.