cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Add new SimBeamSpotHLLHC CondFormat

Open francescobrivio opened this issue 2 years ago • 43 comments

PR description:

First step of resolving https://github.com/cms-AlCaDB/AlCaTools/issues/95:

  • Added a new SimBeamSpotHLLHC CondFormat and relative record
    • Also added all the needed utilities to write/read/plot/inspect/test the new object
  • Updated HLLHCEvtVtxGenerator plugin adding the possibility to read the smearing parameters from the DB
  • Removed the CrabKissing parameters:
    • Removing HLLHC_CK and HLLHC_CK14TeV scenarios which are not used anywhere in CMSSW and are not even supported by any c++ code since #16942

PR validation:

Code compiles and I ran successfully a few upgrade workflows.

Backport:

Not a backport, no backport needed.

francescobrivio avatar Nov 03 '23 22:11 francescobrivio

@cmsbuild please test

francescobrivio avatar Nov 03 '23 22:11 francescobrivio

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/37510

  • This PR adds an extra 80KB to repository

cmsbuild avatar Nov 03 '23 22:11 cmsbuild

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • CondCore/BeamSpotPlugins (db)
  • CondCore/Utilities (db)
  • CondFormats/BeamSpotObjects (alca, db)
  • CondFormats/DataRecord (alca, db)
  • CondTools/BeamSpot (alca, db)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @civanch, @francescobrivio, @saumyaphor4252, @consuegs, @mdhildreth can you please review it and eventually sign? Thanks. @seemasharmafnal, @grzanka, @missirol, @tocheng, @PonIlya, @rsreds, @mmusich, @fabiocos, @yuanchao this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Nov 03 '23 22:11 cmsbuild

-1

Failed Tests: UnitTests RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23df1/35591/summary.html COMMIT: 9cff8571d072757bc554477b3002da405c05f856 CMSSW: CMSSW_13_3_X_2023-11-03-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @fwyzard cms-sw/cmssw#43163
  • @wpmccormack cms-sw/cmssw#43138
  • @bsunanda cms-sw/cmssw#43161
  • @abdoulline cms-sw/cmssw#43171
  • @trackreco cms-sw/cmssw#43145
  • @Prasant1993 cms-sw/cmssw#43028
  • @francescobrivio cms-sw/cmssw#43160
  • @bsunanda cms-sw/cmssw#43178
  • @tvami cms-sw/cmssw#43165
  • @aandvalenzuela cms-sw/cmssw#43034

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23df1/35591/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23df1/35591/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

RelVals

----- Begin Fatal Exception 04-Nov-2023 00:30:42 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetFromMiniAODAK4/CHS/Central/modelfile/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 04-Nov-2023 00:30:43 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetFromMiniAODAK4/CHS/Central/modelfile/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 04-Nov-2023 00:30:44 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetFromMiniAODAK4/CHS/Central/modelfile/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/35591/CMSSW_13_3_X_2023-11-03-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02809/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-11-03-1100/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
  • 136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
  • 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
Expand to see more relval errors ...

cmsbuild avatar Nov 04 '23 00:11 cmsbuild

@cmsbuild please test

francescobrivio avatar Nov 05 '23 16:11 francescobrivio

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23df1/35613/summary.html COMMIT: 9cff8571d072757bc554477b3002da405c05f856 CMSSW: CMSSW_13_3_X_2023-11-05-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43186/35613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 361 lines from the logs
  • Reco comparison results: 134 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 1787
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361201
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Nov 05 '23 18:11 cmsbuild

+1

civanch avatar Nov 06 '23 08:11 civanch

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

smuzaffar avatar Nov 06 '23 16:11 smuzaffar

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/37549

  • This PR adds an extra 16KB to repository

cmsbuild avatar Nov 07 '23 11:11 cmsbuild

Pull request #43186 was updated. @mdhildreth, @cmsbuild, @saumyaphor4252, @civanch, @consuegs, @perrotta, @francescobrivio can you please check and sign again.

cmsbuild avatar Nov 07 '23 11:11 cmsbuild

Sorry for late review. I think PR is in a good shape. Could you please elaborate more on the plan? (or point to the discussion). Thx.

srimanob avatar Dec 04 '23 14:12 srimanob

@francescobrivio what is the status of the discussion on this PR? Should we find a forum for it (AlCa meeting, or SIM meeting as it was proposed before the Holidays)?

perrotta avatar Jan 24 '24 09:01 perrotta

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

cmsbuild avatar Feb 06 '24 10:02 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40323

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40323/cms-checkout-topic.log

cmsbuild avatar May 23 '24 18:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40323

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40323/cms-checkout-topic.log

That's understood, I will rebase after the discussion tomorrow at the Simulation meeting.

Here I just spotted a typo and I fixed from the online GH interface, so I won't forget it when I rebase.

francescobrivio avatar May 23 '24 18:05 francescobrivio

@francescobrivio please clarify status / plans of this PR.

mmusich avatar Jun 26 '24 07:06 mmusich

@francescobrivio please clarify status / plans of this PR.

We haven't received any feedback. @srimanob told me he was going to get in touch with Rogelio and the HL-LHC experts...Phat did you get any feedback?

If not, maybe we can proceed with this PR for now and eventually adapt/change the HL-LHC BS in the future?

francescobrivio avatar Jun 26 '24 07:06 francescobrivio

Hi @francescobrivio I propose we go as is for now. I don't think we will have new updates for list of variables. Thx.

srimanob avatar Jun 26 '24 07:06 srimanob

Hi @francescobrivio I propose we go as is for now. I don't think we will have new updates for list of variables. Thx.

Ok thanks Phat! I'll rebase and proceed with the next steps of the integration asap!

francescobrivio avatar Jun 26 '24 07:06 francescobrivio

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40720

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40720/cms-checkout-topic.log

cmsbuild avatar Jun 26 '24 08:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40723

  • This PR adds an extra 80KB to repository

cmsbuild avatar Jun 26 '24 10:06 cmsbuild

Pull request #43186 was updated. @civanch, @cmsbuild, @consuegs, @francescobrivio, @mdhildreth, @perrotta, @saumyaphor4252 can you please check and sign again.

cmsbuild avatar Jun 26 '24 10:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40725

  • This PR adds an extra 72KB to repository

cmsbuild avatar Jun 26 '24 12:06 cmsbuild

Pull request #43186 was updated. @antoniovilela, @civanch, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @francescobrivio, @mdhildreth, @perrotta, @rappoccio, @saumyaphor4252 can you please check and sign again.

cmsbuild avatar Jun 26 '24 12:06 cmsbuild

@cmsbuild please test

francescobrivio avatar Jun 26 '24 12:06 francescobrivio

@cms-sw/alca-l2 @cms-sw/simulation-l2 @srimanob this PR is now ready for review!

francescobrivio avatar Jun 26 '24 12:06 francescobrivio

-1

Failed Tests: Build ClangBuild Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23df1/40084/summary.html COMMIT: d6b3a517ea0265e5c867ea7090378f16b9d73d4e CMSSW: CMSSW_14_1_X_2024-06-26-1200/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43186/40084/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/IOMC/EventVertexGenerators/src/PassThroughEvtVtxGenerator.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-26-1200' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-26-1200' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-26-1200/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/clhep/2.4.7.1-8e40efd27b7394c1fa4e9c7e432d85cd/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/gsl/2.6-5e2ce72ea2977ff21a2344bbb52daf5c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/hepmc/2.06.10-cb64022df5945e7e8948ec2000290943/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/lcg/root/6.30.07-5b5d83179d6ed7bc60aa7a5006899eba/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-3ca740c03e68b1a067f3ed0679234a78/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/hepmc3/3.2.7-eb6cff961e18f5c7426af506351f9026/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/OpenBLAS/0.3.15-c877ab57fa7b04ce290093588c6c5717/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/IOMC/EventVertexGenerators/src/IOMCEventVertexGenerators/PassThroughEvtVtxGenerator.cc.d src/IOMC/EventVertexGenerators/src/PassThroughEvtVtxGenerator.cc -o tmp/el8_amd64_gcc12/src/IOMC/EventVertexGenerators/src/IOMCEventVertexGenerators/PassThroughEvtVtxGenerator.cc.o
>> Compiling edm plugin src/IOMC/EventVertexGenerators/src/module.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-26-1200' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-26-1200' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-26-1200/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/clhep/2.4.7.1-8e40efd27b7394c1fa4e9c7e432d85cd/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/gsl/2.6-5e2ce72ea2977ff21a2344bbb52daf5c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/hepmc/2.06.10-cb64022df5945e7e8948ec2000290943/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/lcg/root/6.30.07-5b5d83179d6ed7bc60aa7a5006899eba/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-3ca740c03e68b1a067f3ed0679234a78/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/hepmc3/3.2.7-eb6cff961e18f5c7426af506351f9026/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/OpenBLAS/0.3.15-c877ab57fa7b04ce290093588c6c5717/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/IOMC/EventVertexGenerators/src/IOMCEventVertexGenerators/module.cc.d src/IOMC/EventVertexGenerators/src/module.cc -o tmp/el8_amd64_gcc12/src/IOMC/EventVertexGenerators/src/IOMCEventVertexGenerators/module.cc.o
src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc: In member function 'void HLLHCEvtVtxGenerator::update(const edm::EventSetup&)':
src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:95:36: error: 'cm' was not declared in this scope; did you mean 'CLHEP::cm'?
   95 |     fMeanX = beamhandle->meanX() * cm;
      |                                    ^~
      |                                    CLHEP::cm
In file included from src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:12:
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/external/clhep/2.4.7.1-8e40efd27b7394c1fa4e9c7e432d85cd/include/CLHEP/Units/SystemOfUnits.h:103:27: note: 'CLHEP::cm' declared here

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package CondFormats/BeamSpotObjects
>> Entering Package CondFormats/DataRecord
>> Entering Package CondTools/BeamSpot
>> Entering Package IOMC/EventVertexGenerators
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-06-26-1200
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-26-1200/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package CondCore/BeamSpotPlugins
Entering library rule at src/CondCore/BeamSpotPlugins/plugins
>> Compiling edm plugin src/CondCore/BeamSpotPlugins/plugins/BeamSpotOnline_PayloadInspector.cc

cmsbuild avatar Jun 26 '24 12:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43186/40726

  • This PR adds an extra 72KB to repository

cmsbuild avatar Jun 26 '24 12:06 cmsbuild

Pull request #43186 was updated. @antoniovilela, @civanch, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @francescobrivio, @mdhildreth, @perrotta, @rappoccio, @saumyaphor4252 can you please check and sign again.

cmsbuild avatar Jun 26 '24 12:06 cmsbuild

@cmsbuild please test

francescobrivio avatar Jun 26 '24 12:06 francescobrivio