cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[12_4_X] L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list - backport

Open vukasinmilosevic opened this issue 3 years ago • 1 comments

L1T DQM update:

Putting the uGT timing sequence back into the workflow Updating relevant triggers to match the Run 3 menu (L1Menu_Collisions2022_v1_0_1)

Backport of #38840 to be included in the online L1T DQM workflow

vukasinmilosevic avatar Oct 14 '22 14:10 vukasinmilosevic

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @missirol this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #38840

cmsbuild avatar Oct 14 '22 14:10 cmsbuild

please test

emanueleusai avatar Oct 18 '22 17:10 emanueleusai

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23bd9e/28342/summary.html COMMIT: 56b42f6499134b2530593c18320317b83a74aec7 CMSSW: CMSSW_12_4_X_2022-10-18-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39734/28342/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675164
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3675134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1476.3699999999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 147.637 KiB L1T/L1TStage2uGT
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 18 '22 20:10 cmsbuild

testing at p5

emanueleusai avatar Oct 20 '22 05:10 emanueleusai

+1

  • tested and deployed at p5

emanueleusai avatar Oct 21 '22 06:10 emanueleusai

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 21 '22 06:10 cmsbuild

backport of https://github.com/cms-sw/cmssw/pull/38840

perrotta avatar Oct 21 '22 07:10 perrotta

@vukasinmilosevic the 12_5_X backport is still missing: please don't forget it! I'd suggest to hold the merging of this PR until the 12_5_X backport is also made available, in order not to forget it.

perrotta avatar Oct 21 '22 07:10 perrotta

hold

  • Will hold until the 12_5 backport is available, otherwise this looks ready.

rappoccio avatar Oct 21 '22 13:10 rappoccio

Pull request has been put on hold by @rappoccio They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Oct 21 '22 13:10 cmsbuild

unhold

perrotta avatar Nov 02 '22 20:11 perrotta

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Nov 02 '22 20:11 cmsbuild

+1

perrotta avatar Nov 04 '22 07:11 perrotta