cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Update Phase-2 Tracker and HGCAL HLT config files

Open srimanob opened this issue 3 years ago • 5 comments

PR description:

This is the same as the draft PR https://github.com/cms-sw/cmssw/pull/39450 without updating the DQM.

This PR updates module and pset used in Phase-2 Tracker and HGCAL HLT. The update follows what defined in

  • https://github.com/cms-sw/cmssw/blob/master/SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py
  • https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/SiPhase2Clusterizer/python/phase2TrackerClusterizer_cfi.py

To complete on PR test, and example of benefit from the new workflow, this PR also introduces a new workfow .76 which the DIGI and HLT:@relval2026 steps are running together instead of HLT:@fake. The new workflow will allow us to develop Phase2 HLT DQM and sequence to be used in future Phase-2 production.

Note that,

  • We still keep HLT:@fake2 in the main Phase-2 as the new workflow does not validate yet
  • This PR is an effort to help on validation as mentioned in https://github.com/cms-sw/cmssw/issues/39362.

PR validation:

Run test with the following workflows:

  • 20834.75: To make sure that Phase-2 HLT is still running properly.
  • 20834.76: To show that DIGI and HLT:@relval2026 can run together.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

None.

srimanob avatar Oct 14 '22 12:10 srimanob

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39733/32576

  • This PR adds an extra 48KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #39722, #39670, #33532

cmsbuild avatar Oct 14 '22 12:10 cmsbuild

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @AdrianoDee, @bbilin, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. @makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @silviodonato, @trtomei, @beaucero, @slomeo this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 14 '22 12:10 cmsbuild

test parameters:

  • workflows = 20834.76
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

srimanob avatar Oct 14 '22 12:10 srimanob

@cmsbuild please test

srimanob avatar Oct 14 '22 12:10 srimanob

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39733/32577

  • This PR adds an extra 48KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #39722, #39670, #33532

cmsbuild avatar Oct 14 '22 12:10 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c0ab3/28260/summary.html COMMIT: e947b319e6e51cf361f9446f190dda6ff032821c CMSSW: CMSSW_12_6_X_2022-10-14-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39733/28260/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c0ab3/20834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c0ab3/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • Reco comparison had 7 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391133
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 14 '22 17:10 cmsbuild

+Upgrade

This PR fixes the configuration and psets used by Phase-2 HLT step. The new workflow is added, to run both DIGI and HLT together.

srimanob avatar Oct 15 '22 11:10 srimanob

+hlt

It's not specific to the new wf, but this warning should either be investigated, or demoted to a LogDebug:

%MSG-w L1TrackJetEmulationProducer:   L1TrackJetEmulationProducer:l1tTrackJetsEmulation
 14-Oct-2022 16:53:55 CEST  Run: 1 Event: 1
L1TrkPtrs Not Assigned!

FYI: @cms-sw/l1-l2

missirol avatar Oct 15 '22 13:10 missirol

Kind ping to @cms-sw/pdmv-l2 for the review of this PR.

missirol avatar Oct 17 '22 07:10 missirol

+pdmv

kskovpen avatar Oct 17 '22 07:10 kskovpen

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 17 '22 07:10 cmsbuild

+1

rappoccio avatar Oct 17 '22 13:10 rappoccio