cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Possible fix for y-axis range of fit-results plot

Open dinardo opened this issue 3 years ago • 3 comments

PR description:

Possible fix for y-axis range of fit-results plot DQM application: BeamPixel The plot App. status vs Lumisection has a y-axis which leaves one item out, basically, it's too short. Though when testing the application locally on lxplus the histogram range is correct I'm attaching the histogram output as it appears on the online DQM GUI: FatalRootError is outside the y-axis

PR validation:

I've tested that it compiles but like I said, I can not test it because it works on lxplus Let's see whether the SetRangeUser fixes it also online

dinardo avatar Oct 14 '22 12:10 dinardo

I would like to include @francescobrivio that helped me to have a look at this issue.

dinardo avatar Oct 14 '22 12:10 dinardo

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39732/32575

  • This PR adds an extra 20KB to repository

cmsbuild avatar Oct 14 '22 12:10 cmsbuild

A new Pull Request was created by @dinardo (Mauro) for master.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @mmusich, @francescobrivio this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 14 '22 12:10 cmsbuild

hi @dinardo please modify the PR title so it refers to the online DQM of BeamPixel. As of now the title is super general and could refer to literally any plot in CMSSW.

tvami avatar Oct 17 '22 13:10 tvami

@cmsbuild , please test

  • tho I understand we need the DQM online to really test this

tvami avatar Oct 17 '22 13:10 tvami

Thanks Tvami. I modified the title.

dinardo avatar Oct 17 '22 13:10 dinardo

We need a 12_4 backport to test online. Generally in cases where the online test is the only way to verify the PR works as intended we would not approve master before seeing the results of the tests at p5 on the 12_backport

emanueleusai avatar Oct 17 '22 13:10 emanueleusai

Hi @emanueleusai , here it is: https://github.com/cms-sw/cmssw/pull/39744

dinardo avatar Oct 17 '22 14:10 dinardo

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-505eab/28299/summary.html COMMIT: f0bf03db5e2fb0138cd6c0bc9d4c8b3734f0c74c CMSSW: CMSSW_12_6_X_2022-10-17-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39732/28299/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-505eab/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 84
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 17 '22 17:10 cmsbuild

@cmsbuild , please test

tvami avatar Oct 17 '22 20:10 tvami

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-505eab/28315/summary.html COMMIT: f0bf03db5e2fb0138cd6c0bc9d4c8b3734f0c74c CMSSW: CMSSW_12_6_X_2022-10-17-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39732/28315/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_20150/jenkins/workspace/compare-root-files-short-matrix/data/PR-505eab/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 84
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 17 '22 23:10 cmsbuild

+db

tvami avatar Oct 18 '22 11:10 tvami

this PR (albeit not harmful) seems unnecessary, see https://github.com/cms-sw/cmssw/pull/39744#issuecomment-1283563716

mmusich avatar Oct 19 '22 07:10 mmusich

-db

  • not useful PR, see https://github.com/cms-sw/cmssw/pull/39732#issuecomment-1283565583

francescobrivio avatar Oct 19 '22 07:10 francescobrivio