cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Run3-alca232 Update the scripts to make offline analysis of muon data in calibrating HCAL

Open bsunanda opened this issue 3 years ago • 6 comments

PR description:

Update the scripts to make offline analysis of muon data in calibrating HCAL

PR validation:

Use the scripts to take a look at the low luminosity data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Oct 14 '22 11:10 bsunanda

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39731/32572

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39731/32572/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39731/32572/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 14 '22 11:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39731/32573

  • This PR adds an extra 40KB to repository

cmsbuild avatar Oct 14 '22 11:10 cmsbuild

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Calibration/HcalCalibAlgos (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. @mmusich, @tocheng this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 14 '22 11:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 14 '22 11:10 bsunanda

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39731/32574

  • This PR adds an extra 36KB to repository

cmsbuild avatar Oct 14 '22 11:10 cmsbuild

Pull request #39731 was updated. @malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

cmsbuild avatar Oct 14 '22 11:10 cmsbuild

please test

ChrisMisan avatar Oct 17 '22 17:10 ChrisMisan

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1486bc/28309/summary.html COMMIT: 259b4989d4cb9b925ae7a1bb5677a2c13c4982f5 CMSSW: CMSSW_12_6_X_2022-10-17-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39731/28309/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1486bc/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 84
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 17 '22 21:10 cmsbuild

+alca

  • differences in JetMet and Btag are unrelated

ChrisMisan avatar Oct 18 '22 08:10 ChrisMisan

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 18 '22 08:10 cmsbuild

+1

  • HCAL analysis macros

perrotta avatar Oct 18 '22 08:10 perrotta