Remove 'TSGForOI' module

[andrea21z]

PR description:

This PR is created to remove a module that are not used anymore in production: TSGForOI from RecoMuon/TrackerSeedGenerator.

• The issue is described in #37973.
• The deprecated module was replaced by TSGForOIFromL2 in 2018, and this one was replaced in April by TSGForOIDNN (RecoMuon/TrackerSeedGenerator/plugins/TSGForOIDNN.h).
• Files related with this module have been removed.
• We update the L3MuonProducer test to run TSGForOIDNN instead of TSGForOI.

PR validation:

The proposed changes passed all code format and runTheMatrix tests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39726/32563

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @andrea21z for master.

It involves the following packages:

• RecoMuon/L3MuonProducer (hlt, reconstruction)
• RecoMuon/TrackerSeedGenerator (reconstruction)

@cmsbuild, @missirol, @mandrenguyen, @clacaputo, @Martin-Grunewald can you please review it and eventually sign? Thanks. @bellan, @silviodonato, @andrea21z, @abbiendi, @JanFSchulte, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

@khaosmos93 @wonpoint4 @cms-sw/muon-pog-l2

Could you please confirm that this producer can be removed?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77775a/28236/summary.html COMMIT: 37c3f891e71223914d097ce0e2ccf2fb09b0611b CMSSW: CMSSW_12_6_X_2022-10-13-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39726/28236/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/20834.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/20834.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/20896.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/20900.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/21034.999_TTbar_14TeV+2026D88PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/23234.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3392309
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3392287
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

assign muon-pog

See question in https://github.com/cms-sw/cmssw/pull/39726#issuecomment-1277801148.

[cmsbuild]

New categories assigned: muon-pog

@JanFSchulte,@gkaratha you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39726/32571

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #39726 was updated. @Martin-Grunewald, @gkaratha, @JanFSchulte, @clacaputo, @cmsbuild, @missirol, @mandrenguyen can you please check and sign again.

[mandrenguyen]

please test

[missirol]

please abort

Let's save resources.

The file in test/ still needs to be either fixed or removed based on the preference of the MUO POG. That file is not tested in PR tests (well, it is not tested anywhere..), and it is the only thing that changed wrt previous tests.

[missirol]

@cms-sw/muon-pog-l2

Could you please review this PR?

[khaosmos93]

Hi @missirol, we confirm that it can be safely removed, sorry for the delayed answer.

[missirol]

Thanks, @khaosmos93 . There is a pending item, https://github.com/cms-sw/cmssw/pull/39726#discussion_r995631175. The newL3.py file is currently broken (python3 newL3.py does not work). I suggest to fix it, unless you prefer to remove it. Please let @andrea21z know your feedback.

(I wasn't sure whether 'can be removed' refers only to the plugin, or also to the python test config.)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39726/32596

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #39726 was updated. @Martin-Grunewald, @gkaratha, @JanFSchulte, @clacaputo, @cmsbuild, @missirol, @mandrenguyen can you please check and sign again.

[missirol]

unassign muon-pog

I take https://github.com/cms-sw/cmssw/pull/39726#issuecomment-1280773412 as a sign-off of this PR by the MUO POG.

[missirol]

+hlt

Since the only difference is the removal of a file that wasn't used anywhere, the upcoming tests should pass just like they did before.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77775a/28305/summary.html COMMIT: 854f31f72bfb0ac8f7bb6820658bbc40e244cc02 CMSSW: CMSSW_12_6_X_2022-10-17-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39726/28305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77775a/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 90
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391046
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1