cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Add tracking only PU workflows

Open AdrianoDee opened this issue 3 years ago • 11 comments

PR description:

This PR adds to the matrix the trackingOnly wfs with PU.

PR validation:

Running 11834.1 and 21034.1.

AdrianoDee avatar Oct 13 '22 09:10 AdrianoDee

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39722/32557

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #39670, #33532, #39450

cmsbuild avatar Oct 13 '22 10:10 cmsbuild

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. @makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 13 '22 10:10 cmsbuild

test parameters:

  • workflows = 11834.1, 22224.1
  • relvals_opt= -w upgrade

AdrianoDee avatar Oct 13 '22 10:10 AdrianoDee

please test

AdrianoDee avatar Oct 13 '22 10:10 AdrianoDee

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebe618/28220/summary.html COMMIT: 6dec60d500efb11157a6892c7cf53f0a47d51069 CMSSW: CMSSW_12_6_X_2022-10-12-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39722/28220/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 13-Oct-2022 13:22:08 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

cmsbuild avatar Oct 13 '22 12:10 cmsbuild

Just a historical note, when introducing the trackingOnly workflow I did not bother to add a version with pileup because for local use it was easy to use runTheMatrix.py to generate the configuration and change the input files manually to the desired ones (that could include pileup). Back then the purpose of having the workflow run in IBs was merely to ensure the workflow staying functional.

makortel avatar Oct 13 '22 13:10 makortel

Indeed, I would add it to the release since I've received some requests about PU wf running tracking only that could be used for developments and it could ease things up.

Anyway, I've tested the 22224.0 (that should have not been touched by this release) locally and it fails with the same error. Seems more a problem of the wf itself that I have to understand. In the meanwhile I'd restart the tests with the D88 one, TuneCP5 that was the one I actually intended to test.

AdrianoDee avatar Oct 13 '22 16:10 AdrianoDee

test parameters:

  • workflows = 11834.1, 21034.1
  • relvals_opt= -w upgrade

AdrianoDee avatar Oct 13 '22 16:10 AdrianoDee

please test

AdrianoDee avatar Oct 13 '22 16:10 AdrianoDee

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebe618/28241/summary.html COMMIT: 6dec60d500efb11157a6892c7cf53f0a47d51069 CMSSW: CMSSW_12_6_X_2022-10-13-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39722/28241/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/11834.1_TTbar_14TeV+2021PU_trackingOnly+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoNanoPU+HARVESTNanoPU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/20834.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/20834.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/20896.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/20900.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/21034.1_TTbar_14TeV+2026D88PU_trackingOnly+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/21034.999_TTbar_14TeV+2026D88PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/23234.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3392309
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3392287
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 13 '22 20:10 cmsbuild

+Upgrade

This PR add PU for tracking only workflows. Tested workflows, 11834.1, 21034.1, run fine.

srimanob avatar Oct 14 '22 02:10 srimanob

Kindly ping @cms-sw/pdmv-l2

srimanob avatar Oct 25 '22 15:10 srimanob

@cmsbuild please test

Retrigger the test after almost 2 weeks.

srimanob avatar Oct 25 '22 15:10 srimanob

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebe618/28497/summary.html COMMIT: 6dec60d500efb11157a6892c7cf53f0a47d51069 CMSSW: CMSSW_12_6_X_2022-10-25-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39722/28497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/11834.1_TTbar_14TeV+2021PU_trackingOnly+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoNanoPU+HARVESTNanoPU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ebe618/21034.1_TTbar_14TeV+2026D88PU_trackingOnly+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3378384
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3378359
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 25 '22 19:10 cmsbuild

just to understand what's still pending here? @cms-sw/pdmv-l2

mmusich avatar Nov 10 '22 18:11 mmusich

+pdmv

kskovpen avatar Nov 10 '22 19:11 kskovpen

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Nov 10 '22 19:11 cmsbuild

+1

rappoccio avatar Nov 10 '22 21:11 rappoccio