cms-sw
Fix thread safety issues in L1Trigger/Phase2L1GMT
PR description:
Made function static variables std::atomic. This was found by the static analyzer.
PR validation:
Code compiles.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39718/32551
- This PR adds an extra 16KB to repository
A new Pull Request was created by @Dr15Jones (Chris Jones) for master.
It involves the following packages:
- L1Trigger/Phase2L1GMT (l1)
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea627/28296/summary.html
COMMIT: 48daa623c3fef9716b2c8699e438d3a9b355790e
CMSSW: CMSSW_12_6_X_2022-10-16-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39718/28296/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2ea627/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc
Summary:
- No significant changes to the logs found
- Reco comparison results: 11 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3391158
- DQMHistoTests: Total failures: 9
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391127
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 201 log files, 48 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
