cms-sw
Integration of AJJGenJetFilter to CMSSW_10_6_X
PR description:
Integration of AJJGenJetFilter to CMSSW_10_6_X. This filter as currently on master branch
A new Pull Request was created by @hbecerri for CMSSW_10_6_X.
It involves the following packages:
- GeneratorInterface/GenFilters (generators)
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
- Backported from #35547
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-449e52/28294/summary.html
COMMIT: 651fd780a130cb4db5b434eae20c4f862f4bbc6c
CMSSW: CMSSW_10_6_X_2022-10-16-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39706/28294/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 2 differences found in the comparisons
- DQMHistoTests: Total files compared: 35
- DQMHistoTests: Total histograms compared: 3215686
- DQMHistoTests: Total failures: 2
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3215350
- DQMHistoTests: Total skipped: 334
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
- Checked 143 log files, 29 edm output root files, 35 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Pull request #39706 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.
Hello @perrotta, I cleaned the file and Implemented your comments
Thank you @hbecerri I did not realize that this was submitted to 10_6_X. Is this PR the backport of some PR already merged in master? Is so, please indicate it in the PR description. If not, please follow the usual path of submitting and merging in the master first, and then backport in the past release cycle(s)
Hello @perrotta. Yes, this is already in master and we want to integrate it in 10_6_X. I have changed the PR description. please let me know if it is not clear.
@hbecerri which PR (number)? In which releases is it included (i.e. do we need other backports besides this 10_6)?
@perrotta PR: #35981, #35547, It is included in 12_1_X and 11_0_X. We needed on CMSSW_10_6_30_patch1 to UL MC_production
Ok, I finally reconstructed the backport line.
So, before this can be merged in 10_6 please prepare a PR in master with the latest fixes integrated here.
Moreover, in the master you should also take care of the comments posted in that old PR by @Dr15Jones (see https://github.com/cms-sw/cmssw/pull/35547/files#r726169540 and https://github.com/cms-sw/cmssw/pull/35547/files#r726169761, no need to implement them in this PR even if it wouldn't hurt)
Hello @perrotta, I have created the PR to implements the fixes mentioned here. #39788
Hi @all, PR #39788 is closed. Is there something I should to continue with this one? Thanks!
@cms-sw/generators-l2 I think this is ready to get merged in 10_6_X: please have a look at it at your earliest convenience
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-449e52/28485/summary.html
COMMIT: cde73057555b721e5fd469757ed475ae348f15c0
CMSSW: CMSSW_10_6_X_2022-10-23-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39706/28485/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 0 differences found in the comparisons
- DQMHistoTests: Total files compared: 35
- DQMHistoTests: Total histograms compared: 3215686
- DQMHistoTests: Total failures: 1
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3215351
- DQMHistoTests: Total skipped: 334
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
- Checked 143 log files, 29 edm output root files, 35 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
