cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Add new LumiCorrectionsSummary plot for Payload Inspector

Open radla118 opened this issue 3 years ago • 4 comments

PR description:

New class containing the plot with the luminosity corrections vs bunch crossing ID is added to the Payload Inspector module in order to visualize the luminosity corrections with the software.

PR validation:

Tested by running the script testLumiCorrections.sh (based on getPayloadData.py).

No backport is needed.

radla118 avatar Oct 10 '22 13:10 radla118

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39690/32515

  • This PR adds an extra 12KB to repository

cmsbuild avatar Oct 10 '22 13:10 cmsbuild

A new Pull Request was created by @radla118 for master.

It involves the following packages:

  • CondCore/LuminosityPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. @mmusich this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 10 '22 13:10 cmsbuild

@cmsbuild , please test

tvami avatar Oct 11 '22 12:10 tvami

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33ebb3/28171/summary.html COMMIT: e1156b79c061f32b5091a904eb8f580419822054 CMSSW: CMSSW_12_6_X_2022-10-11-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39690/28171/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-33ebb3/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3392309
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3392278
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 11 '22 17:10 cmsbuild

+db

  • dedicated unit test passes

tvami avatar Oct 17 '22 14:10 tvami

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 17 '22 14:10 cmsbuild

+1

perrotta avatar Oct 17 '22 17:10 perrotta