PPS proton reco update to use new LHCInfoPer* records
PR description:
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Before submitting your pull requests, make sure you followed this checklist:
- verify that the PR is really intended for the chosen branch
- verify that changes follow CMS Naming, Coding, And Style Rules
- verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39686/32499
-
This PR adds an extra 36KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/EventSetupsController.h modified in PR(s): #39673
- File FWCore/Framework/src/EventProcessor.cc modified in PR(s): #39673
- File FWCore/Framework/src/EventSetupsController.cc modified in PR(s): #39673
A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.
It involves the following packages:
- CalibPPS/ESProducers (alca)
- CondFormats/RunInfo (db, alca)
- FWCore/Framework (core)
- FWCore/ParameterSet (core)
- RecoPPS/ProtonReconstruction (reconstruction)
@smuzaffar, @Dr15Jones, @malbouis, @makortel, @ChrisMisan, @saumyaphor4252, @clacaputo, @cmsbuild, @yuanchao, @ggovi, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. @makortel, @forthommel, @wddgit, @missirol, @tocheng, @grzanka, @mmusich, @fabferro, @seemasharmafnal this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39686/32500
- This PR adds an extra 40KB to repository
Pull request #39686 was updated. @malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.
assign core
- Matti had some comments
New categories assigned: core
@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks
I don't think my comments would require a core signature
unassign core
- see https://github.com/cms-sw/cmssw/pull/39686#issuecomment-1273482577
hi @JanChyczynski @grzanka any news on this PR?
-reconstruction
hi @JanChyczynski @grzanka any news on this PR?
Not yet, unfortunately. Studies and working part-time hit me hard :/ But I'll get back to working on this PR soon and try do finish it, and the next one, in the upcoming 2 weeks.
hi @JanChyczynski do you have any updates?
hi @JanChyczynski do you have any updates?
Not much progress yet. I'm working on the PopCon PR now. On friday I'll discuss these PRs and what are the most important things to do now with Valentina and I'll accelerate things afterwards.
-1
- until an update on the PR, let's remove it from the alca/db queues
Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.