cms-sw
B2G HLT DQM threshold and binning changes
PR description:
Updating the B2G DQM code with a few small threshold and binning changes to improve their readability and make them useful also with smaller statistics, in the context of preparing using the multi-run harvesting tool under development in the STEAM subgroup.
The only expected changes of this PR are in the B2G HLT monitoring histograms, there are no other changes or dependencies.
PR validation:
The PR was tested by running the DQM code on a RelVal sample to ensure the relevant histograms are filled and properly binned. The relevant test commands were run.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39684/32494
- This PR adds an extra 16KB to repository
A new Pull Request was created by @finnlabe (Finn Labe) for master.
It involves the following packages:
- DQMOffline/Trigger (dqm)
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daf389/28166/summary.html
COMMIT: 1f9ada5ef7ec3b7bd7df5e982f365a55342448eb
CMSSW: CMSSW_12_6_X_2022-10-10-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39684/28166/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-daf389/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3392309
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3392281
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -0.468 KiB( 48 files compared)
- DQMHistoSizes: changed ( 11634.0,... ): -0.078 KiB HLT/B2G
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
