cmssw
cmssw copied to clipboard
cms-sw
PPS automatic workflows for timing calibration
PR description:
This PR adds a set of configuration files for offline calibration workflow described in: https://indico.cern.ch/event/1200233/contributions/5049293/attachments/2511413/4316826/PPS%20Timing%20Calibration%20talk.pdf s.11
and:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/CTPPSTimeCalibration
PR validation:
Those files are intended only for the offline use, details on how to run them are included in: https://twiki.cern.ch/twiki/bin/viewauth/CMS/CTPPSTimeCalibration
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
no backport is needed
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32453
- This PR adds an extra 20KB to repository
A new Pull Request was created by @ChrisMisan (Christopher) for master.
It involves the following packages:
- CalibPPS/TimingCalibration (alca)
- DQM/CTPPS (dqm)
@malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @tocheng, @fabferro, @mmusich, @grzanka this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
hi @ChrisMisan I made a few comments in one file, but they apply to all of the configs.
Should we also make these into a unit test? This wont be tested with the relval wf-s right?
hi @ChrisMisan I made a few comments in one file, but they apply to all of the configs.
Should we also make these into a unit test? This wont be tested with the relval wf-s right?
@tvami Thanks for the comments, I'll address them in the next commit. As for the unit test, I'm not sure. I can test if the script was executed successfully but it really doesn't give any useful information about the final outcome as it just submits jobs to crab. Do we have any mechanisms in place to test for crab jobs?
Hi Chris, no I was just thinking about running
DiamondSampicCalibrationWorker_cfg.py
DiamondSampicCalibrationHarvester_cfg.py
DiamondCalibrationHarvester_cfg.py
DiamondCalibrationWorker_cfg.py
directly locally in a unit test, we for sure dont need to do anything with CRAB here
Hi Chris, no I was just thinking about running
DiamondSampicCalibrationWorker_cfg.py DiamondSampicCalibrationHarvester_cfg.py DiamondCalibrationHarvester_cfg.py DiamondCalibrationWorker_cfg.pydirectly locally in a unit test, we for sure dont need to do anything with CRAB here
Ah, ok, then I think it can be arranged, I'll take a look and add it into next commit.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32482
- This PR adds an extra 16KB to repository
Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a44d/28115/summary.html
COMMIT: c9493ec4f4ee75f5fdf8f8709dcc989a98e07fed
CMSSW: CMSSW_12_6_X_2022-10-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39652/28115/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found errors in the following unit tests:
---> test testHptdcPcl had ERRORS
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3391103
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391078
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32489
- This PR adds an extra 20KB to repository
Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32490
- This PR adds an extra 16KB to repository
Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a44d/28126/summary.html
COMMIT: e32a94ed914245d62dfba19cac24de263f30f539
CMSSW: CMSSW_12_6_X_2022-10-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39652/28126/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found errors in the following unit tests:
---> test testHptdcPcl had ERRORS
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 5 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3391103
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391075
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32491
- This PR adds an extra 20KB to repository
Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a44d/28127/summary.html
COMMIT: 938d2ed1fa6cce65161a1a3abe8ed519c7aee625
CMSSW: CMSSW_12_6_X_2022-10-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39652/28127/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found errors in the following unit tests:
---> test testHptdcPcl had ERRORS
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 1 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3391103
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391078
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
hi @ChrisMisan please use local tests before triggering a test in the Jenkins
Alright, it seems there was an issue with accessing the input file, locally test was running just fine. Now it should be fixed. Also, this test only runs hptdc, we don't have necessary payload in db to test sampic pcl.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32492
- This PR adds an extra 20KB to repository
Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a44d/28130/summary.html
COMMIT: 7c1e84bc7d57b1216ebfbc75a3d98007e0b55bb3
CMSSW: CMSSW_12_6_X_2022-10-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39652/28130/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found errors in the following unit tests:
---> test testHptdcPcl had ERRORS
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /pool/condor/dir_17358/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3391103
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391078
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32495
- This PR adds an extra 20KB to repository
Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.