cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

GE21-ME21 segment reconstruction (backport of #39441, 12_4_X)

Open slowmoyang opened this issue 2 years ago • 3 comments

PR description:

Backport of #39441. This PR introduces the GE21-ME21 segment reconstruction.

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #39441 and is opened under @emanueleusai 's suggestion.

@jshlee @watson-ij

slowmoyang avatar Oct 04 '22 11:10 slowmoyang

A new Pull Request was created by @slowmoyang (slowmoyang) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • DQM/GEM (dqm)
  • DQM/Integration (dqm)
  • RecoLocalMuon/GEMCSCSegment (upgrade, reconstruction)

@perrotta, @rappoccio, @pmandrik, @mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @clacaputo, @syuvivida, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. @batinkov, @missirol, @makortel, @battibass, @jhgoh, @fabiocos, @Martin-Grunewald, @bellan, @watson-ij, @trtomei, @threus, @beaucero, @francescobrivio this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #39441

cmsbuild avatar Oct 04 '22 11:10 cmsbuild

type gem

clacaputo avatar Oct 06 '22 12:10 clacaputo

please test

clacaputo avatar Oct 06 '22 12:10 clacaputo

please test

emanueleusai avatar Oct 17 '22 06:10 emanueleusai

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5e371/28295/summary.html COMMIT: 716ac2bdd47a362e9ef144dfe2d613cc3b868351 CMSSW: CMSSW_12_4_X_2022-10-16-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39595/28295/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-fed_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-hcal_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-hcalreco_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
and more ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675164
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 17 '22 09:10 cmsbuild

testing at p5

emanueleusai avatar Oct 20 '22 05:10 emanueleusai

+1

  • test at p5 completed successfully
  • PR deployed to online DQM systems

emanueleusai avatar Oct 21 '22 06:10 emanueleusai

+1

mandrenguyen avatar Oct 21 '22 09:10 mandrenguyen

backport of https://github.com/cms-sw/cmssw/pull/39441

perrotta avatar Oct 25 '22 21:10 perrotta

hold (see https://github.com/cms-sw/cmssw/pull/39441#issuecomment-1263794531 and previous entries in the github thread)

perrotta avatar Oct 26 '22 08:10 perrotta

Pull request has been put on hold by @perrotta They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Oct 26 '22 08:10 cmsbuild

Backport not needed any more (it was merged in the online DQM release, anyhow)

perrotta avatar Dec 12 '22 15:12 perrotta