cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Require the AlpakaService to be enabled before running on a Device

Open fwyzard opened this issue 3 years ago • 12 comments

PR description:

Require the AlpakaService to be enabled before running on a Device.

Move the check that the corresponding AlpakaService is enabled from the beginStream() method of each EDProducer to the alpakatools::chooseDevice() central function.

This replicates the behaviour currently used by the CUDA "framework".

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 12.5.x.

fwyzard avatar Sep 25 '22 16:09 fwyzard

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39498/32249

  • This PR adds an extra 12KB to repository

cmsbuild avatar Sep 25 '22 16:09 cmsbuild

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. @makortel, @missirol, @rovere this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Sep 25 '22 16:09 cmsbuild

please test

fwyzard avatar Sep 25 '22 16:09 fwyzard

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27763/summary.html COMMIT: 8971c275bb5745c6adcd8db94c4eff8042f69cf3 CMSSW: CMSSW_12_6_X_2022-09-25-0000/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39498/27763/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @Dr15Jones cms-sw/cmssw#38983
  • @civanch cms-sw/cmssw#39494

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27763/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27763/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3624368
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3624335
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Sep 26 '22 00:09 cmsbuild

Good point, I'll give it some more thoughts.

fwyzard avatar Sep 26 '22 22:09 fwyzard

enable gpu

fwyzard avatar Oct 03 '22 16:10 fwyzard

please test

fwyzard avatar Oct 03 '22 16:10 fwyzard

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39498/32373

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File HeterogeneousCore/AlpakaInterface/interface/vec.h modified in PR(s): #39546
    • File HeterogeneousCore/AlpakaInterface/interface/workdivision.h modified in PR(s): #39546
    • File HeterogeneousCore/AlpakaInterface/test/BuildFile.xml modified in PR(s): #39546
    • File HeterogeneousCore/AlpakaInterface/test/alpaka/testVec.cc modified in PR(s): #39546
    • File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): #39546

cmsbuild avatar Oct 03 '22 16:10 cmsbuild

Pull request #39498 was updated. @makortel, @fwyzard can you please check and sign again.

cmsbuild avatar Oct 03 '22 16:10 cmsbuild

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27947/summary.html COMMIT: 5e92241f5231411e8f4b0568ed2c5ea20a67086d CMSSW: CMSSW_12_6_X_2022-10-03-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39498/27947/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250202.184250202.184_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25_RDPix+DIGIPRMXLOCALUP18_PU25_RDPix+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25_RDPix+DIGIPRMXLOCALUP18_PU25_RDPix+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log
  • 500207.0500207.0_NuGun_UP15+NuGun_UP15INPUT+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50/step2_NuGun_UP15+NuGun_UP15INPUT+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50.log
  • 250200.17DAS Error
Expand to see more relval errors ...
  • 250200.18
  • 250202.171
  • 250202.172
  • 250202.2
  • 250202.5
  • 250203.18
  • 250204.18
  • 250205.18
  • 250206.18
  • 250207.17
  • 250207.18
  • 250208.17
  • 250208.18
  • 500202.0
  • 500205.0
  • 500206.0

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-91987d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432622
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19802
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 03 '22 22:10 cmsbuild

please test

fwyzard avatar Oct 03 '22 22:10 fwyzard

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27957/summary.html COMMIT: 5e92241f5231411e8f4b0568ed2c5ea20a67086d CMSSW: CMSSW_12_6_X_2022-10-03-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39498/27957/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-91987d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432622
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19868
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 04 '22 03:10 cmsbuild

Rebased.

fwyzard avatar Oct 28 '22 12:10 fwyzard

enable gpu

fwyzard avatar Oct 28 '22 12:10 fwyzard

please test

fwyzard avatar Oct 28 '22 12:10 fwyzard

+heterogeneous

fwyzard avatar Oct 28 '22 12:10 fwyzard

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39498/32818

  • This PR adds an extra 12KB to repository

cmsbuild avatar Oct 28 '22 12:10 cmsbuild

Pull request #39498 was updated. can you please check and sign again.

cmsbuild avatar Oct 28 '22 12:10 cmsbuild

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/28603/summary.html COMMIT: 1a3bb770bbec8fcae45045dd5b4c2963371fbd3d CMSSW: CMSSW_12_6_X_2022-10-28-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39498/28603/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416356
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416331
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19867
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 28 '22 18:10 cmsbuild

+1

  • Relval input failures unrelated to this PR.

rappoccio avatar Oct 28 '22 19:10 rappoccio

merge (in the status of "test-rejected" an explicit merge is needed)

perrotta avatar Oct 28 '22 19:10 perrotta